Skip to content

Commit 598c4f6

Browse files
gijzelaerrclaude
andauthored
Fix broken build configs: .readthedocs.yaml and Dockerfile (#594)
Fix .readthedocs.yaml referencing non-existent requirements-dev.txt by using pip install with doc extras from pyproject.toml instead. Update Dockerfile to remove unnecessary C snap7 library dependencies (libsnap7-dev, libsnap7-1) since python-snap7 3.0 is pure Python. Update image description label. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 38e9bee commit 598c4f6

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

.readthedocs.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,8 @@ sphinx:
1212

1313
python:
1414
install:
15-
- requirements: requirements-dev.txt
15+
- method: pip
16+
path: .
17+
extra_requirements:
18+
- doc
19+
- cli

Dockerfile

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,11 @@ FROM ubuntu:24.04
22
ENV DEBIAN_FRONTEND=noninteractive
33

44
LABEL org.opencontainers.image.source=https://github.com/gijzelaerr/python-snap7
5-
LABEL org.opencontainers.image.description="The snap7 library is used to communicate with Siemens S7 PLCs. This is a Python wrapper for the snap7 library."
5+
LABEL org.opencontainers.image.description="Pure Python S7 communication library for interfacing with Siemens S7 PLCs."
66
LABEL org.opencontainers.image.licenses=MIT
77

88
RUN apt update \
9-
&& apt install -y software-properties-common python3-pip python3-venv \
10-
&& add-apt-repository ppa:gijzelaar/snap7 \
11-
&& apt update \
12-
&& apt install -y libsnap7-dev libsnap7-1
9+
&& apt install -y python3-pip python3-venv
1310
ADD . /code
1411
WORKDIR /venv
1512
RUN python3 -m venv /venv

0 commit comments

Comments
 (0)