Allow google drive upload by preventing continuous 401 auth failure due to invalid token string interpolation#1943
Open
lavneetpuri wants to merge 1 commit into
Open
Conversation
prevent continuous 401 failure during google drive upload due to invalid string interpolation of token object of form `{ "grantedScopes": [ "..." ], "token": "..." }`
codeCraft-Ritik
left a comment
codeCraft-Ritik
left a comment
There was a problem hiding this comment.
Nice catch! Correctly extracting the actual token value from the options object should prevent subtle authentication issues.
Appreciate the note about this being a stopgap fix and the openness to architectural improvements 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MediaUploader constructor assigns
this.token = options.token;but options.token is an object of form{ "grantedScopes": [ "..." ], "token": "..." }. This proposed change instantiates the token property correctly.Note: This is a stopgap fix that works on the local copy. Feel free to suggest changes as appropriate, taking into account the larger project structure and architecture.