Skip to content

Add --browser-single-process option (#193) #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madcow wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add --browser-single-process option (#193) #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ async function launchBrowser(options = {}, indexPath = 0) {
args.push("--proxy-server=" + options.httpProxyServer);
}
args.push("--user-data-dir=" + profilePath);
args.push("--single-process");
if (options.singleProcess) {
args.push("--single-process");
}
if (options.args) {
const argNames = options.args.map(arg => arg.split("=")[0]);
args = args.filter(arg => !argNames.includes(arg.split("=")[0]));
Expand Down
1 change: 1 addition & 0 deletions options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ const OPTIONS_INFO = [{
"browser-debug": { description: "Enable debug mode", type: "boolean" },
"browser-arg": { description: "Argument passed to the browser", type: "string[]", alias: "browser-argument" },
"browser-args": { description: "Arguments provided as a JSON array and passed to the browser", type: "string" },
"browser-single-process": { description: "Run the browser as a single process", type: "boolean", defaultValue: true },
"browser-start-minimized": { description: "Minimize the browser", type: "boolean" },
"browser-ignore-insecure-certs": { description: "Ignore HTTPs errors", type: "boolean" },
"browser-remote-debugging-URL": { description: "Remote debugging URL", type: "string" }
Expand Down