Skip to content

Commit 27e84e6

Browse files
committed
added missing error handling
1 parent 787f3b0 commit 27e84e6

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

src/CloudStorage.h

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,8 @@ class BaseCloudStorage {
116116
DynamicJsonDocument root(1024);
117117
DeserializationError error = deserializeJson(root, response.body);
118118

119-
// TODO: handle error
119+
if(error) return cloud_storage_utils::ResultWrapper<Ty>(false);
120+
120121
return cloud_storage_utils::ResultWrapper<Ty>(
121122
!root["error"],
122123
getValueByKey<Ty>(root["result"], key)
@@ -429,7 +430,9 @@ class BaseCloudStorage {
429430
// Parse response body and extract the wanted value
430431
DynamicJsonDocument root(1024);
431432
DeserializationError error = deserializeJson(root, response.body);
432-
// TODO: handle error
433+
434+
if(error) return cloud_storage_utils::ResultWrapper<Ty>(false);
435+
433436
return cloud_storage_utils::ResultWrapper<Ty>(
434437
!root["error"],
435438
getValueByKey<Ty>(root["result"], key)
@@ -473,7 +476,9 @@ class BaseCloudStorage {
473476
// Parse response body and extract the wanted value
474477
DynamicJsonDocument root(1024);
475478
DeserializationError error = deserializeJson(root, response.body);
476-
// TODO: handle errors
479+
480+
if(error) return cloud_storage_utils::ResultWrapper<Ty>(false);
481+
477482
return cloud_storage_utils::ResultWrapper<Ty>(
478483
!root["error"],
479484
root["result"]

0 commit comments

Comments
 (0)