Skip to content

Fix the split_handle sticking issue. #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yanxiyimengya wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the split_handle sticking issue. #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 28 additions & 13 deletions addons/dockable_container/split_handle.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,34 @@ func _draw() -> void:

func _gui_input(event: InputEvent) -> void:
if event is InputEventMouseButton and event.button_index == MOUSE_BUTTON_LEFT:
_dragging = event.is_pressed()
if event.double_click:
layout_split.percent = 0.5
elif _dragging and event is InputEventMouseMotion:
var mouse_in_parent := get_parent_control().get_local_mouse_position()
if layout_split.is_horizontal():
layout_split.percent = (
(mouse_in_parent.x - _parent_rect.position.x) / _parent_rect.size.x
)
else:
layout_split.percent = (
(mouse_in_parent.y - _parent_rect.position.y) / _parent_rect.size.y
)
if event.pressed:
_dragging = true
if event.double_click:
layout_split.percent = 0.5
accept_event()


func _input(event: InputEvent) -> void:
if not _dragging:
return
if event is InputEventMouseButton and event.button_index == MOUSE_BUTTON_LEFT:
if not event.is_pressed():
_dragging = false
get_viewport().set_input_as_handled()
Copy link
Copy Markdown
Owner

@gilzoide gilzoide Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this branch calls set_input_as_handled, while the one for the mouse motion without left button pressed (if block at line 50) does not?

elif event is InputEventMouseMotion:
if (event.button_mask & MOUSE_BUTTON_MASK_LEFT) == 0:
_dragging = false
return
_perform_resize_logic()
get_viewport().set_input_as_handled()


func _perform_resize_logic() -> void:
var mouse_in_parent := get_parent_control().get_local_mouse_position()
if layout_split.is_horizontal():
layout_split.percent = ((mouse_in_parent.x - _parent_rect.position.x) / _parent_rect.size.x)
else:
layout_split.percent = ((mouse_in_parent.y - _parent_rect.position.y) / _parent_rect.size.y)


func _notification(what: int) -> void:
Expand Down