Simplify code#113
Merged
Merged
Conversation
mlange-42
reviewed
Sep 16, 2025
mlange-42
reviewed
Sep 16, 2025
mlange-42
reviewed
Sep 16, 2025
Improve readability by switching to imperative code from functional code.
Replace match with if to show primary flow.
Change content of group_offset to include offset 0 at index 0. Convert code from functional to imperative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Straighten out small part of code so they are easier to understand.
The method is to do things one step at a time, instead of large functions that does everything.