#519: fix an issue where special characters in the git URL simply yield: Illegal character in authority

Author: TheSnoozer

core/src/main/java/pl/project13/core/GitDataProvider.java

@@ -25,6 +25,8 @@
 
 import javax.annotation.Nonnull;
 import java.net.URI;
+import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
 import java.util.*;
 import java.text.SimpleDateFormat;
 import java.util.concurrent.atomic.AtomicBoolean;
@@ -299,6 +301,15 @@ protected String stripCredentialsFromOriginUrl(String gitRemoteString) throws Gi
     }
     // At this point, we should have a properly formatted URL
     try {
+
+      for (String s: Arrays.asList(
+              // escape all 'delims' characters in a URI as per https://www.ietf.org/rfc/rfc2396.txt
+              "<", ">", "#", "%", "\"",
+              // escape all 'unwise' characters in a URI as per https://www.ietf.org/rfc/rfc2396.txt
+              "{", "}", "|", "\\", "^", "[", "]", "`")) {
+        gitRemoteString = gitRemoteString.replaceAll(
+                Pattern.quote(s), URLEncoder.encode(s, StandardCharsets.UTF_8.toString()));
+      }
       URI original = new URI(gitRemoteString);
       String userInfoString = original.getUserInfo();
       if (null == userInfoString) {
@@ -329,4 +340,4 @@ protected String stripCredentialsFromOriginUrl(String gitRemoteString) throws Gi
       return "";
     }
   }
-}
+}

maven/src/test/java/pl/project13/core/UriUserInfoRemoverTest.java

@@ -52,6 +52,15 @@ public static Collection<Object[]> parameters() {
             { "file:///path/to/repo.git/", "file:///path/to/repo.git/"},
             { "file:///C:\\Users\\test\\example", "file:///C:\\Users\\test\\example"},
             { "file://C:\\Users\\test\\example", "file://C:\\Users\\test\\example" },
+            // use of 'reserved' characters as https://www.ietf.org/rfc/rfc2396.txt
+            // note: left out '/' since we can't simply escape it
+            { "https://user:A;?:@&=+$,Z@example.com:8888", "https://user@example.com:8888" },
+            // use of 'unreserved' characters as https://www.ietf.org/rfc/rfc2396.txt
+            { "https://user:A-_.!~*'()Z@example.com:8888", "https://user@example.com:8888" },
+            // use of 'delims' characters as https://www.ietf.org/rfc/rfc2396.txt
+            { "https://user:A<>#%\"Z@example.com:8888", "https://user@example.com:8888" },
+            // use of 'unwise' characters as https://www.ietf.org/rfc/rfc2396.txt
+            { "https://user:A{}|\\^[]`Z@example.com:8888", "https://user@example.com:8888" },
     };
     return Arrays.asList(data);
   }