#519: drop the '?', '@' and from the test-cases for 'reserved' characters - as per rfc2396 we can assume those chacters are escaped - if not there is still no harm done the remote-URL is simply not available as property

Author: TheSnoozer

core/src/main/java/pl/project13/core/GitDataProvider.java

@@ -281,6 +281,31 @@ public static <T> SupplierEx<T> memoize(SupplierEx<T> delegate) {
   /**
    * If the git remote value is a URI and contains a user info component, strip the password from it if it exists.
    *
+   * Note that this method will return an empty string if any failure occurred, while stripping the password from the
+   * credentials. This merely serves as save-guard to avoid any potential password exposure inside generated properties.
+   *
+   * This method further operates on the assumption that a valid URL schema follows the rules outlined in
+   * <a href=https://www.ietf.org/rfc/rfc2396.txt>RFC-2396</a> in section "3.2.2. Server-based Naming Authority"
+   * which declares the following as valid URL schema:
+   *  <pre>
+   *  <userinfo>@<host>:<port>
+   *  </pre>
+   *  The "userinfo" part is declared in the same section allowing the following pattern:
+   *  <pre>
+   *    userinfo = *( unreserved | escaped | ";" | ":" | "&" | "=" | "+" | "$" | "," )
+   *  </pre>
+   *  The "unreserved" part is declared in section "2.3. Unreserved Characters" as the following:
+   *  <pre>
+   *    unreserved  = alphanum | mark
+   *    mark = "-" | "_" | "." | "!" | "~" | "*" | "'" | "(" | ")"
+   *
+   *    alphanum = alpha | digit
+   *    digit = "0" | "1" | "2" | "3" | "4" | "5" | "6" | "7" |  "8" | "9"
+   *    alpha = lowalpha | upalpha
+   *    lowalpha = "a" | "b" | "c" | ... | "x" | "y" | "z"
+   *    upalpha = "A" | "B" | "C" | ... | "X" | "Y" | "Z"
+   *  </pre>
+   *
    * @param gitRemoteString The value of the git remote
    * @return returns the gitRemoteUri with stripped password (might be used in http or https)
    * @throws GitCommitIdExecutionException Exception when URI is invalid

maven/src/test/java/pl/project13/core/UriUserInfoRemoverTest.java

@@ -52,14 +52,14 @@ public static Collection<Object[]> parameters() {
             { "file:///path/to/repo.git/", "file:///path/to/repo.git/"},
             { "file:///C:\\Users\\test\\example", "file:///C:\\Users\\test\\example"},
             { "file://C:\\Users\\test\\example", "file://C:\\Users\\test\\example" },
-            // use of 'reserved' characters as https://www.ietf.org/rfc/rfc2396.txt
-            // note: left out '/' since we can't simply escape it
-            { "https://user:A;?:@&=+$,Z@example.com:8888", "https://user@example.com:8888" },
-            // use of 'unreserved' characters as https://www.ietf.org/rfc/rfc2396.txt
+            // Must Support: use of 'unreserved' characters as https://www.ietf.org/rfc/rfc2396.txt, Section "2.3. Unreserved Characters"
             { "https://user:A-_.!~*'()Z@example.com:8888", "https://user@example.com:8888" },
-            // use of 'delims' characters as https://www.ietf.org/rfc/rfc2396.txt
+            // Optional Support: use of 'reserved' characters as https://www.ietf.org/rfc/rfc2396.txt, Section "2.2. Reserved Characters"
+            // note: left out '/', '?', '@' since we technically expect user's need to escape those
+            { "https://user:A;:&=+$,Z@example.com:8888", "https://user@example.com:8888" },
+            // Optional Support: use of 'delims' characters as https://www.ietf.org/rfc/rfc2396.txt, Section "2.4.3. Excluded US-ASCII Characters"
             { "https://user:A<>#%\"Z@example.com:8888", "https://user@example.com:8888" },
-            // use of 'unwise' characters as https://www.ietf.org/rfc/rfc2396.txt
+            // Optional Support: use of 'unwise' characters as https://www.ietf.org/rfc/rfc2396.txt, Section "2.4.3. Excluded US-ASCII Characters"
             { "https://user:A{}|\\^[]`Z@example.com:8888", "https://user@example.com:8888" },
     };
     return Arrays.asList(data);