Added protection from NullPointerException when dotGitDirectory is wrong.#140
Merged
ktoso merged 1 commit intogit-commit-id:masterfrom Nov 27, 2014
Merged
Added protection from NullPointerException when dotGitDirectory is wrong.#140ktoso merged 1 commit intogit-commit-id:masterfrom
ktoso merged 1 commit intogit-commit-id:masterfrom
Conversation
Collaborator
|
Looks good, thanks! |
ktoso
added a commit
that referenced
this pull request
Nov 27, 2014
Added protection from NullPointerException when dotGitDirectory is wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I put wrong path to .git dir in
dotGitDirectoryproperty I received NullPointerExceptionAfter my fix:
I believe second exception is much more descriptive. And the problem is quite trivial - revWalk variable in JGitProvider didn't have chance to instantiate and because of that it's rather tough to execute revWalk.dispose() ;) What do you think about my simple fix?