fix for Allow initialization once per run (with multiple modules) #53#143
fix for Allow initialization once per run (with multiple modules) #53#143dtrucken wants to merge 4 commits intogit-commit-id:masterfrom
Conversation
…-commit-id#53 Added a new optional configuration parameter ‘runOnlyOnce’
There was a problem hiding this comment.
maybe reword this: variables => maven properties?
There was a problem hiding this comment.
sure, what ever maven calls these things: ${git.branch}, do you want me to
change the name and perform another commit ?
On Wed, Dec 3, 2014 at 9:51 AM, Konrad Malawski notifications@github.com
wrote:
In src/main/java/pl/project13/maven/git/GitCommitIdMojo.java:
@@ -257,6 +258,19 @@
private boolean skip = false;/**
- * In a multi-module build, only run once. This probably won't "do the right thing" if your project has more than
- * one git repository. If you use this with the option 'generateGitPropertiesFile', it will only generate (or update)
- * the file in the directory where you started your build.
- * The git.* variables are available in all modules.
variables => maven properties?
—
Reply to this email directly or view it on GitHub
https://github.com/ktoso/maven-git-commit-id-plugin/pull/143/files#r21240166
.
|
Now only adding documentation in |
|
hopefully enough for you to consider including this in the next release? |
|
Needs a bit more love, but I should be able to take it from here tomorrow and then cut a release. |
|
I'll merge manually - to keep this feature in one commit. |
|
Merged manually 19918d4 |
2 participants
Added a new optional configuration parameter ‘runOnlyOnce’