simplify tests

Author: TheSnoozer

src/test/java/pl/project13/core/GitCommitIdPluginIntegrationTest.java

@@ -1743,15 +1743,16 @@ public void verifyAllowedCharactersForEvaluateOnCommit() {
     Assertions.assertFalse(p.matcher("&&cat /etc/passwd").matches());
   }
 
-  @Test
-  public void shouldGiveCommitIdForEachFolderWhenPerModuleVersionsEnabled() throws Exception {
+  @ParameterizedTest
+  @MethodSource("useNativeGit")
+  public void shouldGiveCommitIdForEachFolderWhenPerModuleVersionsEnabled(boolean useNativeGit) throws Exception {
     // given
     File dotGitDirectory = createTmpDotGitDirectory(AvailableGitTestRepo.GIT_COMMIT_ID);
 
     GitCommitIdPlugin.Callback cbSrc =
             new GitCommitIdTestCallback()
                     .setDotGitDirectory(dotGitDirectory)
-                    .setUseNativeGit(false)
+                    .setUseNativeGit(useNativeGit)
                     .setPerModuleVersions(true)
                     .setModuleBaseDir(dotGitDirectory.getParentFile().toPath().resolve("src").toFile())
                     .build();
@@ -1760,43 +1761,20 @@ public void shouldGiveCommitIdForEachFolderWhenPerModuleVersionsEnabled() throws
     GitCommitIdPlugin.Callback cbSrcTest =
             new GitCommitIdTestCallback()
                     .setDotGitDirectory(dotGitDirectory)
-                    .setUseNativeGit(false)
+                    .setUseNativeGit(useNativeGit)
                     .setPerModuleVersions(true)
                     .setModuleBaseDir(dotGitDirectory.getParentFile().toPath().resolve("src/test").toFile())
                     .build();
     Properties propertiesSrcTestFolder = new Properties();
 
-    GitCommitIdPlugin.Callback cbSrcNative =
-            new GitCommitIdTestCallback()
-                    .setDotGitDirectory(dotGitDirectory)
-                    .setUseNativeGit(true)
-                    .setPerModuleVersions(true)
-                    .setModuleBaseDir(dotGitDirectory.getParentFile().toPath().resolve("src").toFile())
-                    .build();
-    Properties propertiesSrcFolderNative = new Properties();
-
-    GitCommitIdPlugin.Callback cbSrcTestNative =
-            new GitCommitIdTestCallback()
-                    .setDotGitDirectory(dotGitDirectory)
-                    .setUseNativeGit(true)
-                    .setPerModuleVersions(true)
-                    .setModuleBaseDir(dotGitDirectory.getParentFile().toPath().resolve("src/test").toFile())
-                    .build();
-    Properties propertiesSrcTestFolderNative = new Properties();
-
     // when
     GitCommitIdPlugin.runPlugin(cbSrc, propertiesSrcFolder);
     GitCommitIdPlugin.runPlugin(cbSrcTest, propertiesSrcTestFolder);
-    GitCommitIdPlugin.runPlugin(cbSrcNative, propertiesSrcFolderNative);
-    GitCommitIdPlugin.runPlugin(cbSrcTestNative, propertiesSrcTestFolderNative);
 
     // then
     assertThat(propertiesSrcFolder).containsKey("git.commit.id");
     assertThat(propertiesSrcTestFolder).containsKey("git.commit.id");
     assertThat(propertiesSrcFolder.getProperty("git.commit.id")).isNotEqualTo(propertiesSrcTestFolder.getProperty("git.commit.id"));
-    assertThat(propertiesSrcFolderNative).containsKey("git.commit.id");
-    assertThat(propertiesSrcTestFolderNative).containsKey("git.commit.id");
-    assertThat(propertiesSrcFolderNative.getProperty("git.commit.id")).isNotEqualTo(propertiesSrcTestFolderNative.getProperty("git.commit.id"));
   }
 
   private GitDescribeConfig createGitDescribeConfig(boolean forceLongFormat, int abbrev) {