linuxsettings: Fix CS0121 string.Split call ambiguity with .NET 8.0

chewi · chewi · commit 271d13eccbb7 · 2026-03-12T09:48:17.000Z
The error in full:

    error CS0121: The call is ambiguous between the following methods or properties: 'string.Split(char[]?, StringSplitOptions)' and 'string.Split(string?, StringSplitOptions)' [src/shared/Core/Core.csproj::TargetFramework=net8.0]

Signed-off-by: James Le Cuirot &lt;jlecuirot@microsoft.com&gt;
diff --git a/src/shared/Core/Interop/Linux/LinuxConfigParser.cs b/src/shared/Core/Interop/Linux/LinuxConfigParser.cs
@@ -31,7 +31,7 @@ public IDictionary<string, string> Parse(string content)
     {
         var result = new Dictionary<string, string>(GitConfigurationKeyComparer.Instance);
 
-        IEnumerable<string> lines = content.Split(['\n'], StringSplitOptions.RemoveEmptyEntries);
+        IEnumerable<string> lines = content.Split(new char[] { '\n' }, StringSplitOptions.RemoveEmptyEntries);
 
         foreach (string line in lines)
         {

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public IDictionary<string, string> Parse(string content)`
`31`	`31`	`{`
`32`	`32`	`var result = new Dictionary<string, string>(GitConfigurationKeyComparer.Instance);`
`33`	`33`
`34`		`- IEnumerable<string> lines = content.Split(['\n'], StringSplitOptions.RemoveEmptyEntries);`
	`34`	`+ IEnumerable<string> lines = content.Split(new char[] { '\n' }, StringSplitOptions.RemoveEmptyEntries);`
`35`	`35`
`36`	`36`	`foreach (string line in lines)`
`37`	`37`	`{`