Skip to content

Commit 4c486f0

Browse files
committed
fix(config): enable file include in scoped query
add parameter to make file include behavior in config read consistent retain existing parameters on write, always uses "primary" scope file
1 parent c4be6b2 commit 4c486f0

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

src/shared/Core/GitConfiguration.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ public void Enumerate(GitConfigurationLevel level, GitConfigurationEnumerationCa
463463

464464
// Fall back to original implementation
465465
string levelArg = GetLevelFilterArg(level);
466-
using (ChildProcess git = _git.CreateProcess($"config --null {levelArg} --list"))
466+
using (ChildProcess git = _git.CreateProcess($"config --null {levelArg} --includes --list"))
467467
{
468468
git.Start(Trace2ProcessClass.Git);
469469
// To avoid deadlocks, always read the output stream first and then wait
@@ -545,7 +545,7 @@ public bool TryGet(GitConfigurationLevel level, GitConfigurationType type, strin
545545
// Fall back to individual git config command if cache not available
546546
string levelArg = GetLevelFilterArg(level);
547547
string typeArg = GetCanonicalizeTypeArg(type);
548-
using (ChildProcess git = _git.CreateProcess($"config --null {levelArg} {typeArg} {QuoteCmdArg(name)}"))
548+
using (ChildProcess git = _git.CreateProcess($"config --null {levelArg} --includes {typeArg} {QuoteCmdArg(name)}"))
549549
{
550550
git.Start(Trace2ProcessClass.Git);
551551
// To avoid deadlocks, always read the output stream first and then wait
@@ -667,7 +667,7 @@ public IEnumerable<string> GetAll(GitConfigurationLevel level, GitConfigurationT
667667
string levelArg = GetLevelFilterArg(level);
668668
string typeArg = GetCanonicalizeTypeArg(type);
669669

670-
var gitArgs = $"config --null {levelArg} {typeArg} --get-all {QuoteCmdArg(name)}";
670+
var gitArgs = $"config --null {levelArg} --includes {typeArg} --get-all {QuoteCmdArg(name)}";
671671

672672
using (ChildProcess git = _git.CreateProcess(gitArgs))
673673
{
@@ -705,7 +705,7 @@ public IEnumerable<string> GetRegex(GitConfigurationLevel level, GitConfiguratio
705705
string levelArg = GetLevelFilterArg(level);
706706
string typeArg = GetCanonicalizeTypeArg(type);
707707

708-
var gitArgs = $"config --null {levelArg} {typeArg} --get-regex {QuoteCmdArg(nameRegex)}";
708+
var gitArgs = $"config --null {levelArg} --includes {typeArg} --get-regex {QuoteCmdArg(nameRegex)}";
709709
if (valueRegex != null)
710710
{
711711
gitArgs += $" {QuoteCmdArg(valueRegex)}";

0 commit comments

Comments
 (0)