Merge pull request #804 from mjcheetham/diagnose-hang

Reorder Git config list process exit wait in diagnose command

Author: mjcheetham

src/shared/Core/Diagnostics/GitDiagnostic.cs

@@ -32,8 +32,10 @@ protected override Task<bool> RunInternalAsync(StringBuilder log, IList<string>
             log.Append("Listing all Git configuration...");
             Process configProc = _git.CreateProcess("config --list --show-origin");
             configProc.Start();
-            configProc.WaitForExit();
+            // To avoid deadlocks, always read the output stream first and then wait
+            // TODO: don't read in all the data at once; stream it
             string gitConfig = configProc.StandardOutput.ReadToEnd().TrimEnd();
+            configProc.WaitForExit();
             log.AppendLine(" OK");
             log.AppendLine("Git configuration:");
             log.AppendLine(gitConfig);