Commit b7f2c83
Lessley Dennington
secret service: fix error creating credential
Multiple Linux users have reported that they are unable to use Secret
Service as their credential store, as GCM throws the following error:
sec_free: Assertion `cell->requested > 0' failed.
The root cause is that we're using the libsecret secret_value_get()
function to obtain secret data, then attempting to free the string with
secret_password_free(). It appears that secret_password_free() is only
meant to be used to free nonpageable memory [1], however. Removing this
call fixes the issue, as verified with a successful git-credential-manager
diagnose (which was previously failing with the above error).
[1] secret_password_free manpage
https://www.manpagez.com/html/libsecret-1/libsecret-1-0.18.6/libsecret-Password-storage.php#secret-password-free1 parent bb3c305 commit b7f2c83
1 file changed
Lines changed: 0 additions & 1 deletion
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
291 | 291 | | |
292 | 292 | | |
293 | 293 | | |
294 | | - | |
295 | 294 | | |
296 | 295 | | |
297 | 296 | | |
| |||
0 commit comments