Skip to content

Check for xdg-open availability on Linux for browser auth #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kyle-rader-msft wants to merge 3 commits into from
+27 −37
Closed

Check for xdg-open availability on Linux for browser auth #2254

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69a1f88
Check for xdg-open availability on Linux for browser auth
kyle-rader-msft Jan 29, 2026
cc81292
Refactor: invert handler check for clearer logic
kyle-rader-msft Jan 29, 2026
0b7e96a
Simplify logic with explicit boolean vars and single return
kyle-rader-msft Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 27 additions & 37 deletions src/shared/Core/Interop/Linux/LinuxSessionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,44 +21,34 @@ public override bool IsWebBrowserAvailable

private bool GetWebBrowserAvailable()
{
// If this is a Windows Subsystem for Linux distribution we may
// be able to launch the web browser of the host Windows OS.
if (WslUtils.IsWslDistribution(Environment, FileSystem, out _))
{
// We need a shell execute handler to be able to launch to browser
if (!BrowserUtils.TryGetLinuxShellExecuteHandler(Environment, out _))
{
return false;
}

//
// If we are in Windows logon session 0 then the user can never interact,
// even in the WinSta0 window station. This is typical when SSH-ing into a
// Windows 10+ machine using the default OpenSSH Server configuration,
// which runs in the 'services' session 0.
//
// If we're in any other session, and in the WinSta0 window station then
// the user can possibly interact. However, since it's hard to determine
// the window station from PowerShell cmdlets (we'd need to write P/Invoke
// code and that's just messy and too many levels of indirection quite
// frankly!) we just assume any non session 0 is interactive.
//
// This assumption doesn't hold true if the user has changed the user that
// the OpenSSH Server service runs as (not a built-in NT service) *AND*
// they've SSH-ed into the Windows host (and then started a WSL shell).
// This feels like a very small subset of users...
//
if (WslUtils.GetWindowsSessionId(FileSystem) == 0)
{
return false;
}
// Determine system properties
bool hasHandler = BrowserUtils.TryGetLinuxShellExecuteHandler(Environment, out _);
bool isWsl = WslUtils.IsWslDistribution(Environment, FileSystem, out _);
bool isWslSession0 = isWsl && WslUtils.GetWindowsSessionId(FileSystem) == 0;
bool isDesktopSession = IsDesktopSession;

// If we are not in session 0, or we cannot get the Windows session ID,
// assume that we *CAN* launch the browser so that users are never blocked.
return true;
}
//
// WSL session 0 note:
// If we are in Windows logon session 0 then the user can never interact,
// even in the WinSta0 window station. This is typical when SSH-ing into a
// Windows 10+ machine using the default OpenSSH Server configuration,
// which runs in the 'services' session 0.
//
// If we're in any other session, and in the WinSta0 window station then
// the user can possibly interact. However, since it's hard to determine
// the window station from PowerShell cmdlets (we'd need to write P/Invoke
// code and that's just messy and too many levels of indirection quite
// frankly!) we just assume any non session 0 is interactive.
//
// This assumption doesn't hold true if the user has changed the user that
// the OpenSSH Server service runs as (not a built-in NT service) *AND*
// they've SSH-ed into the Windows host (and then started a WSL shell).
// This feels like a very small subset of users...
//

// We require an interactive desktop session to be able to launch a browser
return IsDesktopSession;
// We can launch a browser if:
// 1. We have a shell execute handler (xdg-open, wslview, etc.) and not blocked by WSL session 0, OR
// 2. We have a desktop session on non-WSL Linux (backward compatibility - assumes handler exists)
return (hasHandler && !isWslSession0) || (isDesktopSession && !isWsl && !hasHandler);
}
}
Loading