Skip to content

Fix bug when reading linux defaults #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjcheetham merged 1 commit into from
Feb 4, 2026
Merged

Fix bug when reading linux defaults #2259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/shared/Core/Interop/Linux/LinuxSettings.cs
View file
Open in desktop

This comment was marked as spam.

Sign in to view

Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,17 @@ protected internal override bool TryGetExternalDefault(string section, string sc

_extConfigCache ??= ReadExternalConfiguration();

if (_extConfigCache is null)
return false; // No external config found (or failed to read)

string name = string.IsNullOrWhiteSpace(scope)
? $"{section}.{property}"
: $"{section}.{scope}.{property}";

// Check if the setting exists in the configuration
if (!_extConfigCache?.TryGetValue(name, out value) ?? false)
if (!_extConfigCache.TryGetValue(name, out value))
{
// No property exists (or failed to read config)
// No property exists
return false;
}

Expand Down Expand Up @@ -90,4 +93,4 @@ private IDictionary<string, string> ReadExternalConfiguration()
return null;
}
}
}
}
Loading