config: update tests for inline settings

Update config_test.go and summary_test.go to use inline structs instead
of writing temporary YAML files to disk. This reflects the switch from
file-path-based to inline configuration for pii, filter, and summary
settings.

Tests that validated loading from file paths (e.g., nonexistent file
errors) are removed since that responsibility now belongs to the
collector's ${file:PATH} resolver. The remaining tests verify that
Config.Validate() correctly handles inline structs, including
validation of summary field names and detection of duplicates.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>

Author: mjcheetham

config_test.go

@@ -1,13 +1,10 @@
 package trace2receiver
 
 import (
-	"os"
-	"path/filepath"
 	"runtime"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 )
 
 // Test Validate with minimal valid config on Windows
@@ -156,195 +153,111 @@ func Test_Config_Validate_RejectDgramUnix(t *testing.T) {
 	assert.Contains(t, err.Error(), "SOCK_DGRAM sockets are not supported")
 }
 
-// Test Validate with valid PII settings file
+// Test Validate with valid PII settings (inline)
 func Test_Config_Validate_WithValidPiiSettings(t *testing.T) {
-	// Create a temporary PII settings file
-	tmpDir := t.TempDir()
-	piiPath := filepath.Join(tmpDir, "pii.yml")
-	piiContent := `
-pii_filter:
-  domains:
-    - pattern: "example.com"
-      replace: "<domain>"
-`
-	err := os.WriteFile(piiPath, []byte(piiContent), 0644)
-	require.NoError(t, err)
-
-	cfg := createMinimalValidConfig()
-	cfg.PiiSettingsPath = piiPath
-
-	err = cfg.Validate()
-	assert.NoError(t, err)
-	assert.NotNil(t, cfg.piiSettings)
-}
-
-// Test Validate with invalid PII settings file
-func Test_Config_Validate_WithInvalidPiiSettings(t *testing.T) {
 	cfg := createMinimalValidConfig()
-	cfg.PiiSettingsPath = "/nonexistent/pii.yml"
+	cfg.Pii = &PiiSettings{
+		Include: PiiInclude{
+			Hostname: true,
+			Username: false,
+		},
+	}
 
 	err := cfg.Validate()
-	assert.Error(t, err)
-}
-
-// Test Validate with valid filter settings file
-func Test_Config_Validate_WithValidFilterSettings(t *testing.T) {
-	// Create a temporary filter settings file
-	tmpDir := t.TempDir()
-	filterPath := filepath.Join(tmpDir, "filter.yml")
-	filterContent := `
-default_action: accept
-`
-	err := os.WriteFile(filterPath, []byte(filterContent), 0644)
-	require.NoError(t, err)
-
-	cfg := createMinimalValidConfig()
-	cfg.FilterSettingsPath = filterPath
-
-	err = cfg.Validate()
 	assert.NoError(t, err)
-	assert.NotNil(t, cfg.filterSettings)
+	assert.NotNil(t, cfg.Pii)
 }
 
-// Test Validate with invalid filter settings file
-func Test_Config_Validate_WithInvalidFilterSettings(t *testing.T) {
+// Test Validate with valid filter settings (inline)
+func Test_Config_Validate_WithValidFilterSettings(t *testing.T) {
 	cfg := createMinimalValidConfig()
-	cfg.FilterSettingsPath = "/nonexistent/filter.yml"
+	cfg.Filter = &FilterSettings{
+		Defaults: FilterDefaults{
+			RulesetName: "dl:verbose",
+		},
+	}
 
 	err := cfg.Validate()
-	assert.Error(t, err)
-}
-
-// Test Validate with valid summary settings file
-func Test_Config_Validate_WithValidSummary(t *testing.T) {
-	// Create a temporary summary settings file
-	tmpDir := t.TempDir()
-	summaryPath := filepath.Join(tmpDir, "summary.yml")
-	summaryContent := `
-message_patterns:
-  - prefix: "error:"
-    field_name: "error_count"
-  - prefix: "warning:"
-    field_name: "warning_count"
-
-region_timers:
-  - category: "index"
-    label: "do_read_index"
-    count_field: "index_read_count"
-    time_field: "index_read_time"
-`
-	err := os.WriteFile(summaryPath, []byte(summaryContent), 0644)
-	require.NoError(t, err)
-
-	cfg := createMinimalValidConfig()
-	cfg.SummaryPath = summaryPath
-
-	err = cfg.Validate()
 	assert.NoError(t, err)
-	assert.NotNil(t, cfg.summary)
-	assert.Equal(t, 2, len(cfg.summary.MessagePatterns))
-	assert.Equal(t, 1, len(cfg.summary.RegionTimers))
+	assert.NotNil(t, cfg.Filter)
 }
 
-// Test Validate with invalid summary settings file (nonexistent)
-func Test_Config_Validate_WithNonexistentSummary(t *testing.T) {
+// Test Validate with valid summary settings (inline)
+func Test_Config_Validate_WithValidSummary(t *testing.T) {
 	cfg := createMinimalValidConfig()
-	cfg.SummaryPath = "/nonexistent/summary.yml"
+	cfg.Summary = &SummarySettings{
+		MessagePatterns: []MessagePatternRule{
+			{Prefix: "error:", FieldName: "error_count"},
+			{Prefix: "warning:", FieldName: "warning_count"},
+		},
+		RegionTimers: []RegionTimerRule{
+			{Category: "index", Label: "do_read_index", CountField: "index_read_count", TimeField: "index_read_time"},
+		},
+	}
 
 	err := cfg.Validate()
-	assert.Error(t, err)
+	assert.NoError(t, err)
+	assert.NotNil(t, cfg.Summary)
+	assert.Equal(t, 2, len(cfg.Summary.MessagePatterns))
+	assert.Equal(t, 1, len(cfg.Summary.RegionTimers))
 }
 
-// Test Validate with invalid summary settings file (malformed YAML)
+// Test Validate with invalid summary settings (empty field_name)
 func Test_Config_Validate_WithMalformedSummary(t *testing.T) {
-	// Create a temporary malformed summary settings file
-	tmpDir := t.TempDir()
-	summaryPath := filepath.Join(tmpDir, "summary.yml")
-	summaryContent := `
-message_patterns:
-  - prefix: "error:"
-    field_name: ""
-`
-	err := os.WriteFile(summaryPath, []byte(summaryContent), 0644)
-	require.NoError(t, err)
-
 	cfg := createMinimalValidConfig()
-	cfg.SummaryPath = summaryPath
+	cfg.Summary = &SummarySettings{
+		MessagePatterns: []MessagePatternRule{
+			{Prefix: "error:", FieldName: ""},
+		},
+	}
 
-	err = cfg.Validate()
+	err := cfg.Validate()
 	assert.Error(t, err)
 	assert.Contains(t, err.Error(), "field_name cannot be empty")
 }
 
 // Test Validate with summary settings with duplicate field names
 func Test_Config_Validate_WithDuplicateSummaryFields(t *testing.T) {
-	// Create a temporary summary settings file with duplicate fields
-	tmpDir := t.TempDir()
-	summaryPath := filepath.Join(tmpDir, "summary.yml")
-	summaryContent := `
-message_patterns:
-  - prefix: "error:"
-    field_name: "count"
-  - prefix: "warning:"
-    field_name: "count"
-`
-	err := os.WriteFile(summaryPath, []byte(summaryContent), 0644)
-	require.NoError(t, err)
-
 	cfg := createMinimalValidConfig()
-	cfg.SummaryPath = summaryPath
+	cfg.Summary = &SummarySettings{
+		MessagePatterns: []MessagePatternRule{
+			{Prefix: "error:", FieldName: "count"},
+			{Prefix: "warning:", FieldName: "count"},
+		},
+	}
 
-	err = cfg.Validate()
+	err := cfg.Validate()
 	assert.Error(t, err)
 	assert.Contains(t, err.Error(), "duplicate field_name")
 }
 
-// Test Validate with all optional settings valid
+// Test Validate with all optional settings valid (inline)
 func Test_Config_Validate_WithAllOptionalSettings(t *testing.T) {
-	// Create temporary files for all settings
-	tmpDir := t.TempDir()
-
-	piiPath := filepath.Join(tmpDir, "pii.yml")
-	piiContent := `
-pii_filter:
-  domains:
-    - pattern: "example.com"
-      replace: "<domain>"
-`
-	err := os.WriteFile(piiPath, []byte(piiContent), 0644)
-	require.NoError(t, err)
-
-	filterPath := filepath.Join(tmpDir, "filter.yml")
-	filterContent := `
-default_action: accept
-`
-	err = os.WriteFile(filterPath, []byte(filterContent), 0644)
-	require.NoError(t, err)
-
-	summaryPath := filepath.Join(tmpDir, "summary.yml")
-	summaryContent := `
-message_patterns:
-  - prefix: "error:"
-    field_name: "error_count"
-
-region_timers:
-  - category: "index"
-    label: "do_read_index"
-    time_field: "index_read_time"
-`
-	err = os.WriteFile(summaryPath, []byte(summaryContent), 0644)
-	require.NoError(t, err)
-
 	cfg := createMinimalValidConfig()
-	cfg.PiiSettingsPath = piiPath
-	cfg.FilterSettingsPath = filterPath
-	cfg.SummaryPath = summaryPath
+	cfg.Pii = &PiiSettings{
+		Include: PiiInclude{
+			Hostname: true,
+		},
+	}
+	cfg.Filter = &FilterSettings{
+		Defaults: FilterDefaults{
+			RulesetName: "dl:summary",
+		},
+	}
+	cfg.Summary = &SummarySettings{
+		MessagePatterns: []MessagePatternRule{
+			{Prefix: "error:", FieldName: "error_count"},
+		},
+		RegionTimers: []RegionTimerRule{
+			{Category: "index", Label: "do_read_index", TimeField: "index_read_time"},
+		},
+	}
 
-	err = cfg.Validate()
+	err := cfg.Validate()
 	assert.NoError(t, err)
-	assert.NotNil(t, cfg.piiSettings)
-	assert.NotNil(t, cfg.filterSettings)
-	assert.NotNil(t, cfg.summary)
+	assert.NotNil(t, cfg.Pii)
+	assert.NotNil(t, cfg.Filter)
+	assert.NotNil(t, cfg.Summary)
 }
 
 // Test Validate with command control enabled

summary_test.go

@@ -347,7 +347,7 @@ func Test_MessagePatternMatching_Basic(t *testing.T) {
 	}
 	tr2.rcvr_base = &Rcvr_Base{
 		RcvrConfig: &Config{
-			summary: css,
+			Summary: css,
 		},
 	}
 
@@ -380,7 +380,7 @@ func Test_MessagePatternMatching_MultipleMatches(t *testing.T) {
 	}
 	tr2.rcvr_base = &Rcvr_Base{
 		RcvrConfig: &Config{
-			summary: css,
+			Summary: css,
 		},
 	}
 
@@ -403,7 +403,7 @@ func Test_MessagePatternMatching_NoConfig(t *testing.T) {
 	}
 	tr2.rcvr_base = &Rcvr_Base{
 		RcvrConfig: &Config{
-			summary: nil,
+			Summary: nil,
 		},
 	}
 
@@ -432,7 +432,7 @@ func Test_RegionTimerAggregation_Basic(t *testing.T) {
 	}
 	tr2.rcvr_base = &Rcvr_Base{
 		RcvrConfig: &Config{
-			summary: css,
+			Summary: css,
 		},
 	}
 
@@ -482,7 +482,7 @@ func Test_RegionTimerAggregation_CountOnly(t *testing.T) {
 	}
 	tr2.rcvr_base = &Rcvr_Base{
 		RcvrConfig: &Config{
-			summary: css,
+			Summary: css,
 		},
 	}
 
@@ -522,7 +522,7 @@ func Test_RegionTimerAggregation_TimeOnly(t *testing.T) {
 	}
 	tr2.rcvr_base = &Rcvr_Base{
 		RcvrConfig: &Config{
-			summary: css,
+			Summary: css,
 		},
 	}
 
@@ -545,12 +545,12 @@ func Test_RegionTimerAggregation_TimeOnly(t *testing.T) {
 func Test_Summary_EmittedAtSummaryLevel(t *testing.T) {
 	// Create a minimal config with summary
 	cfg := &Config{
-		summary: &SummarySettings{
+		Summary: &SummarySettings{
 			MessagePatterns: []MessagePatternRule{
 				{Prefix: "test_msg:", FieldName: "msgCount"},
 			},
 		},
-		filterSettings: &FilterSettings{},
+		Filter: &FilterSettings{},
 	}
 
 	rcvr := &Rcvr_Base{
@@ -615,7 +615,7 @@ func Test_RegionTimerAggregation_NoMatch(t *testing.T) {
 	}
 	tr2.rcvr_base = &Rcvr_Base{
 		RcvrConfig: &Config{
-			summary: css,
+			Summary: css,
 		},
 	}