git: skip Rust bits in i686 builds#207
Merged
Merged
Conversation
There is no i686 Rust we could use, therefore we have to exclude the Rust bits from the build. One of the next Git versions will make the Rust bits mandatory, at which point we will have to stop building mingw-w64-i686-git. To accommodate the i686 variants of MinGit, which still need to be supported until 2029 (see https://gitforwindows.org/32-bit), that will be the time when we have to branch off a `mingw-w64-git-legacy` package that sticks to a Git version that _does_ allow for NO_RUST, and we will have to switch the `git-sdk-32` to that package. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
rimrul
approved these changes
Jul 1, 2026
dscho
added a commit
that referenced
this pull request
Jul 3, 2026
This was already done as part of b08d188 (mingw-w64-git: upgrade to Git for Windows 2.55.0 (msys2#30227), 2026-06-29), but was inadvertently reverted in the parent commit because I had forgotten to merge #207 in the hectic release process before building the artifacts of Git for Windows v2.55.0(2). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
lazka
pushed a commit
to msys2/MINGW-packages
that referenced
this pull request
Jul 3, 2026
* mingw-w64-git: upgrade to Git for Windows v2.55.0.windows.2 This commit was created by: https://github.com/git-for-windows/git-for-windows-automation/actions/runs/28586498193 See https://github.com/git-for-windows/git/releases/tag/v2.55.0.windows.2 for details. * git: skip Rust bits in i686 builds (again) This was already done as part of b08d188 (mingw-w64-git: upgrade to Git for Windows 2.55.0 (#30227), 2026-06-29), but was inadvertently reverted in the parent commit because I had forgotten to merge git-for-windows#207 in the hectic release process before building the artifacts of Git for Windows v2.55.0(2). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --------- Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
github-actions Bot
pushed a commit
to cygapiss/msys2-apiss
that referenced
this pull request
Jul 3, 2026
…282) * mingw-w64-git: upgrade to Git for Windows v2.55.0.windows.2 This commit was created by: https://github.com/git-for-windows/git-for-windows-automation/actions/runs/28586498193 See https://github.com/git-for-windows/git/releases/tag/v2.55.0.windows.2 for details. * git: skip Rust bits in i686 builds (again) This was already done as part of b08d1887b8 (mingw-w64-git: upgrade to Git for Windows 2.55.0 (#30227), 2026-06-29), but was inadvertently reverted in the parent commit because I had forgotten to merge git-for-windows/MINGW-packages#207 in the hectic release process before building the artifacts of Git for Windows v2.55.0(2). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --------- Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Source: msys2/MINGW-packages@14d8584
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git for Windows builds the mingw-w64-git package with NO_RUST by default. But MSYS2 doesn't, hence the need for this change.
With this PR, the
mingw-w64-git/directory is treesame between msys2 and git-for-windows once again.