Skip to content

Skip distributing git instaweb#689

Merged
dscho merged 2 commits intomainfrom
skip-distributing-instaweb
Apr 14, 2026
Merged

Skip distributing git instaweb#689
dscho merged 2 commits intomainfrom
skip-distributing-instaweb

Conversation

@dscho
Copy link
Copy Markdown
Member

@dscho dscho commented Apr 14, 2026

While analyzing Perl users, I noticed that git instaweb is included in Git for Windows, even if GitWeb (on which it relies) is not.

Let's fix that.

dscho added 2 commits April 14, 2026 12:12
Earlier, when Git for Windows still distributed the `gitweb` files, it
made sense to exclude that explicitly from MinGit.

But since c20f0d6 (Skip gitweb in Git for Windows, 2018-08-14), the
GitWeb files are no longer distributed with Git for Windows, not even
the full installer version thereof, read: They are _already_ excluded
(and therefore do not need to be excluded _again_).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The `git-instaweb` command is meant to make it easy for Git users to
stand up their own ad-hoc GitWeb instance easily.

However, since c20f0d6 (Skip gitweb in Git for Windows,
2018-08-14), Git for Windows no longer includes GitWeb. Therefore
it does not make sense to include `git-instaweb`, either. I
noticed this omission while analyzing what parts of Git for
Windows still require Perl, after `git svn` support was dropped, in
git-for-windows/git#5393 (comment).

So let's move the exclusion from the MinGit-only clause to the general
exclusions.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho requested review from mjcheetham and rimrul April 14, 2026 10:13
@dscho dscho self-assigned this Apr 14, 2026
@dscho
Copy link
Copy Markdown
Member Author

dscho commented Apr 14, 2026

Gah, I wanted to include this in -rc2. Oh well.

@dscho dscho merged commit 888810c into main Apr 14, 2026
21 checks passed
@dscho dscho deleted the skip-distributing-instaweb branch April 14, 2026 21:33
@dscho
Copy link
Copy Markdown
Member Author

dscho commented Apr 14, 2026

/add relnote bug The git instaweb command is no longer distributed with Git for Windows because it would require GitWeb (which has not been distributed with Git for Windows for quite a few years).

The workflow run was started

github-actions Bot pushed a commit that referenced this pull request Apr 14, 2026
The `git instaweb` command [is no longer distributed with Git for
Windows](#689)
because it would require GitWeb (which has not been distributed with Git
for Windows for quite a few years).

Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants