Commit 795d7fc
committed
upload-snapshot: feed the UCRT64 artifacts into the snapshots
The previous commit taught `/git-artifacts` to build the UCRT64 flavor,
but the `upload-snapshot` cascade still only ever waited for, and
forwarded, the three classic architectures. The freshly built UCRT64
bits were therefore dropped on the floor: nothing waited for that run
and nothing handed its ID to the snapshot upload.
Now that the snapshot pipeline can pick those bits up
(git-for-windows/git-for-windows-automation#181
adds an optional `git_artifacts_ucrt64_workflow_run_id` input to
`upload-snapshot.yml`, downloading the UCRT64 artifacts when the input
is supplied), this teaches the helper to supply it.
Both places that dispatch `upload-snapshot.yml` learn about the fourth
architecture: the `git-artifacts` completion cascade in
`cascadingRuns()`, and the push-to-`main` path in `handlePush()`. Adding
`ucrt64` to the loop that gathers the per-architecture run IDs means the
upload is held back until the UCRT64 build has finished, exactly like
the other three, and the gathered ID is then passed along as the new
input.
This deliberately stops at snapshots. The full-release path (`/release`,
which drives `release-git.yml`, and the automation side's own
`architectures` list in `github-release.js`) is left UCRT64-free for the
time being.
Because `upload-snapshot.yml` does not declare the new input until #181
lands, dispatching it with that input beforehand would be rejected, so
this change must not be merged before #181.
Assisted-by: Opus 4.8
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>1 parent 8053838 commit 795d7fc
2 files changed
Lines changed: 10 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
197 | | - | |
| 197 | + | |
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
| |||
258 | 258 | | |
259 | 259 | | |
260 | 260 | | |
| 261 | + | |
261 | 262 | | |
262 | 263 | | |
263 | 264 | | |
| |||
392 | 393 | | |
393 | 394 | | |
394 | 395 | | |
395 | | - | |
| 396 | + | |
396 | 397 | | |
397 | 398 | | |
398 | 399 | | |
| |||
438 | 439 | | |
439 | 440 | | |
440 | 441 | | |
| 442 | + | |
441 | 443 | | |
442 | 444 | | |
443 | 445 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
459 | 459 | | |
460 | 460 | | |
461 | 461 | | |
462 | | - | |
| 462 | + | |
| 463 | + | |
463 | 464 | | |
464 | 465 | | |
465 | 466 | | |
| |||
497 | 498 | | |
498 | 499 | | |
499 | 500 | | |
| 501 | + | |
500 | 502 | | |
501 | 503 | | |
502 | 504 | | |
| |||
1001 | 1003 | | |
1002 | 1004 | | |
1003 | 1005 | | |
1004 | | - | |
| 1006 | + | |
1005 | 1007 | | |
1006 | 1008 | | |
1007 | 1009 | | |
| |||
1057 | 1059 | | |
1058 | 1060 | | |
1059 | 1061 | | |
1060 | | - | |
| 1062 | + | |
| 1063 | + | |
1061 | 1064 | | |
1062 | 1065 | | |
1063 | 1066 | | |
| |||
0 commit comments