Skip to content

Commit 1b4a1a9

Browse files
committed
ci(win+Meson): build in Release mode, avoiding t7001-mv hangs
Since switching to `--vsenv`, the t7001-mv test consistently times out after six hours in the CI builds on GitHub. This kind of waste is inconsistent with my values. The reason for this timeout is the test case 'nonsense mv triggers assertion failure and partially updated index' in t7001-mv (which is not even a regression test, but instead merely demonstrates a bug that someone thought someone else should fix at some time). As the name suggests, it triggers an assertion. The problem with this is that an assertion on Windows, at least when run in Debug mode, will open a modal dialog that patiently awaits some buttons to be clicked. Which never happens in automated builds. The solution is straight-forward: Just like the `win+VS` job already did in forever, build in Release mode (where that modal assertion dialog is never shown). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent d4c413c commit 1b4a1a9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ jobs:
268268
run: pip install meson ninja
269269
- name: Setup
270270
shell: pwsh
271-
run: meson setup build --vsenv -Dperl=disabled -Dcredential_helpers=wincred
271+
run: meson setup build --vsenv -Dbuildtype=release -Dperl=disabled -Dcredential_helpers=wincred
272272
- name: Compile
273273
shell: pwsh
274274
run: meson compile -C build

0 commit comments

Comments
 (0)