Skip to content

Commit 6d68fa2

Browse files
mjcheethamGit for Windows Build Agent
authored andcommitted
t5563: add tests for http.emptyAuth with Negotiate
Add tests exercising the interaction between http.emptyAuth and servers that advertise Negotiate (SPNEGO) authentication. Verify that auto mode gives Negotiate a chance via empty auth (resulting in two 401 responses before falling through to credential_fill with Basic credentials), and that false mode strips Negotiate immediately (only one 401 response). Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
1 parent 14fab7b commit 6d68fa2

1 file changed

Lines changed: 74 additions & 0 deletions

File tree

t/t5563-simple-http-auth.sh

Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -822,4 +822,78 @@ test_expect_success NTLM 'access using NTLM auth' '
822822
git ls-remote "$HTTPD_URL/ntlm_auth/repo.git"
823823
'
824824

825+
test_lazy_prereq SPNEGO 'curl --version | grep -qi "SPNEGO\|GSS-API\|Kerberos\|negotiate"'
826+
827+
test_expect_success SPNEGO 'http.emptyAuth=auto attempts Negotiate before credential_fill' '
828+
test_when_finished "per_test_cleanup" &&
829+
830+
set_credential_reply get <<-EOF &&
831+
username=alice
832+
password=secret-passwd
833+
EOF
834+
835+
# Basic base64(alice:secret-passwd)
836+
cat >"$HTTPD_ROOT_PATH/custom-auth.valid" <<-EOF &&
837+
id=1 creds=Basic YWxpY2U6c2VjcmV0LXBhc3N3ZA==
838+
EOF
839+
840+
cat >"$HTTPD_ROOT_PATH/custom-auth.challenge" <<-EOF &&
841+
id=1 status=200
842+
id=default response=WWW-Authenticate: Negotiate
843+
id=default response=WWW-Authenticate: Basic realm="example.com"
844+
EOF
845+
846+
test_config_global credential.helper test-helper &&
847+
GIT_TRACE_CURL="$TRASH_DIRECTORY/trace-auto" \
848+
git -c http.emptyAuth=auto \
849+
ls-remote "$HTTPD_URL/custom_auth/repo.git" &&
850+
851+
# In auto mode with a Negotiate+Basic server, there should be
852+
# three 401 responses: (1) initial no-auth request, (2) empty-auth
853+
# retry where Negotiate fails (no Kerberos ticket), (3) libcurl
854+
# internal Negotiate retry. The fourth attempt uses Basic
855+
# credentials from credential_fill and succeeds.
856+
grep "HTTP/[0-9.]* 401" "$TRASH_DIRECTORY/trace-auto" >actual_401s &&
857+
test_line_count = 3 actual_401s &&
858+
859+
expect_credential_query get <<-EOF
860+
capability[]=authtype
861+
capability[]=state
862+
protocol=http
863+
host=$HTTPD_DEST
864+
wwwauth[]=Negotiate
865+
wwwauth[]=Basic realm="example.com"
866+
EOF
867+
'
868+
869+
test_expect_success SPNEGO 'http.emptyAuth=false skips Negotiate' '
870+
test_when_finished "per_test_cleanup" &&
871+
872+
set_credential_reply get <<-EOF &&
873+
username=alice
874+
password=secret-passwd
875+
EOF
876+
877+
# Basic base64(alice:secret-passwd)
878+
cat >"$HTTPD_ROOT_PATH/custom-auth.valid" <<-EOF &&
879+
id=1 creds=Basic YWxpY2U6c2VjcmV0LXBhc3N3ZA==
880+
EOF
881+
882+
cat >"$HTTPD_ROOT_PATH/custom-auth.challenge" <<-EOF &&
883+
id=1 status=200
884+
id=default response=WWW-Authenticate: Negotiate
885+
id=default response=WWW-Authenticate: Basic realm="example.com"
886+
EOF
887+
888+
test_config_global credential.helper test-helper &&
889+
GIT_TRACE_CURL="$TRASH_DIRECTORY/trace-false" \
890+
git -c http.emptyAuth=false \
891+
ls-remote "$HTTPD_URL/custom_auth/repo.git" &&
892+
893+
# With emptyAuth=false, Negotiate is stripped immediately and
894+
# credential_fill is called right away. Only one 401 response.
895+
grep "HTTP/[0-9.]* 401" "$TRASH_DIRECTORY/trace-false" >actual_401s &&
896+
test_line_count = 1 actual_401s
897+
'
898+
825899
test_done

0 commit comments

Comments
 (0)