Skip to content

Commit dc04bff

Browse files
committed
ci: bump actions/download-artifact from v6 to v8
We use `actions/download-artifact` to pass build artifacts between the "windows-build" / "vs-build" / "windows-meson-build" jobs and their corresponding test jobs. All callers are currently on v6; bumping to v8 keeps this action in lockstep with the `upload-artifact` bump in the previous commit. What v7 and v8 change: - v7 switches the default runtime from Node.js 20 to Node.js 24 (v6 had preliminary Node 24 support but still defaulted to Node 20). This is the main motivation: it gets us off the deprecated runtime. - v8 makes three further changes: * The package is converted to ESM (invisible to workflow authors). * The action now checks the `Content-Type` header before attempting to unzip a download, so that directly-uploaded (unzipped) artifacts from `upload-artifact` v7 are downloaded correctly. * The `digest-mismatch` behaviour is changed from warn-and- continue to a hard failure by default. Risk analysis: defaulting hash-mismatch to a hard failure is strictly safer than the previous warn-and-continue behaviour -- a mismatch points to real corruption or tampering and should stop the run. We download archives that the same workflow just uploaded, on the same runner fleet, so false positives are not expected. Our usage is limited to the `name` and `path` inputs, which are unchanged between v6 and v8, so the diff is purely the `@vN` identifier. See also: - Release notes: https://github.com/actions/download-artifact/releases - Compare: actions/download-artifact@v6...v8 Originally-authored-by: dependabot[bot] <support@github.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent 2ff3696 commit dc04bff

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ jobs:
140140
cancel-in-progress: ${{ needs.ci-config.outputs.skip_concurrent == 'yes' }}
141141
steps:
142142
- name: download tracked files and build artifacts
143-
uses: actions/download-artifact@v6
143+
uses: actions/download-artifact@v8
144144
with:
145145
name: windows-artifacts
146146
path: ${{github.workspace}}
@@ -226,7 +226,7 @@ jobs:
226226
steps:
227227
- uses: git-for-windows/setup-git-for-windows-sdk@v1
228228
- name: download tracked files and build artifacts
229-
uses: actions/download-artifact@v6
229+
uses: actions/download-artifact@v8
230230
with:
231231
name: vs-artifacts
232232
path: ${{github.workspace}}
@@ -292,7 +292,7 @@ jobs:
292292
shell: pwsh
293293
run: pip install meson ninja
294294
- name: Download build artifacts
295-
uses: actions/download-artifact@v6
295+
uses: actions/download-artifact@v8
296296
with:
297297
name: windows-meson-artifacts
298298
path: build

0 commit comments

Comments
 (0)