Skip to content

Commit 3a2084d

Browse files
committed
AGENTS.md: drop the flavor: full-only caveat on ucrt64
Match the preceding action.yml and README updates. With `please.sh create-sdk-artifact --architecture=ucrt64` now a working invocation, all four flavors take the `getViaGit` path successfully on the `ucrt64` axis, so the table cell and the explanatory paragraph no longer need to single `full` out. The ci-artifacts fast path remains suppressed for `ucrt64` because the `ci-artifacts` release of `git-sdk-64` still carries no UCRT64 asset; reword the paragraph to spell out what that means in practice (every flavor goes through `please.sh`). The table-column realignment is a no-op produced by `npm run format` since the longest cell in the notes column shrank. Assisted-by: Opus 4.7 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent 327ff85 commit 3a2084d

1 file changed

Lines changed: 15 additions & 16 deletions

File tree

AGENTS.md

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -112,28 +112,27 @@ The Action supports four flavors of the SDK:
112112
The `architecture` input drives both the underlying `git-sdk-*` repo
113113
and the `MSYSTEM` / bin-path layout inside the SDK:
114114

115-
| `architecture` | repo | MSYSTEM | mingw bin path | notes |
116-
| -------------- | --------------- | ------------ | ----------------- | -------------------------------------------------------------------------------------- |
117-
| `i686` | `git-sdk-32` | `MINGW32` | `/mingw32/bin` | only `build-installers` and `full` |
118-
| `x86_64` | `git-sdk-64` | `MINGW64` | `/mingw64/bin` | the default; fast path available for `minimal` |
119-
| `aarch64` | `git-sdk-arm64` | `CLANGARM64` | `/clangarm64/bin` | only `full` for now |
120-
| `ucrt64` | `git-sdk-64` | `UCRT64` | `/ucrt64/bin` | UCRT64 migration; cloned from the `ucrt64` branch of `git-sdk-64`; only `full` for now |
115+
| `architecture` | repo | MSYSTEM | mingw bin path | notes |
116+
| -------------- | --------------- | ------------ | ----------------- | ----------------------------------------------------------------- |
117+
| `i686` | `git-sdk-32` | `MINGW32` | `/mingw32/bin` | only `build-installers` and `full` |
118+
| `x86_64` | `git-sdk-64` | `MINGW64` | `/mingw64/bin` | the default; fast path available for `minimal` |
119+
| `aarch64` | `git-sdk-arm64` | `CLANGARM64` | `/clangarm64/bin` | only `full` for now |
120+
| `ucrt64` | `git-sdk-64` | `UCRT64` | `/ucrt64/bin` | UCRT64 migration; cloned from the `ucrt64` branch of `git-sdk-64` |
121121

122122
The `ucrt64` axis is part of the larger UCRT64 migration tracked in
123123
https://github.com/git-for-windows/git-sdk-64/pull/117 and its
124124
follow-up comment
125125
https://github.com/git-for-windows/git-sdk-64/pull/117#issuecomment-4642726384.
126126
It shares the `git-sdk-64` repository with `x86_64` but is materialised
127-
from a different long-lived branch, so caches and on-disk directories
128-
must stay distinct (the artifact name is `git-sdk-ucrt64-<flavor>`
129-
rather than `git-sdk-64-<flavor>`). The `ci-artifacts` release of
130-
`git-sdk-64` contains no UCRT64 asset, so the CI-artifacts fast path
131-
is forcibly skipped for this axis; every flavor takes the
132-
`getViaGit` path. `build-extra`'s `please.sh create-sdk-artifact` does
133-
not yet understand `--architecture=ucrt64` either, so right now only
134-
`flavor: full` (which goes straight through `git worktree add`)
135-
produces a working SDK. The non-`full` flavors will start working once
136-
`build-extra` and the `ci-artifacts` pipeline catch up.
127+
from a separate transitional `ucrt64` branch (which will eventually
128+
replace `main`), so caches and on-disk directories must stay distinct
129+
between the two variants (the artifact name is
130+
`git-sdk-ucrt64-<flavor>` rather than `git-sdk-64-<flavor>`). The
131+
`ci-artifacts` release of `git-sdk-64` contains no UCRT64 asset, so
132+
the CI-artifacts fast path is forcibly skipped for this axis; every
133+
flavor takes the `getViaGit` path, with `please.sh create-sdk-artifact
134+
--architecture=ucrt64` carving the subset flavors out of the full SDK
135+
clone exactly as it does for the other architectures.
137136

138137
## Relationship to other Git for Windows repositories
139138

0 commit comments

Comments
 (0)