Skip to content

Commit 3cd3134

Browse files
committed
test.yml: exercise the ucrt64 subset flavors on every PR
The per-PR `test` matrix already covered `ucrt64` + `full` end-to-end. Now that `please.sh create-sdk-artifact --architecture=ucrt64` works, extend the matrix with the three subset flavors so a regression on the `getViaGit` -> `please.sh` path for `ucrt64` is caught on every PR rather than first surfacing in a consumer repository. `mingw_prefix` stays at `/ucrt64` for all three new rows; the verification step's `$MINGW_PREFIX/bin/gcc` assertion checks the same path on every flavor, since `gcc` is present in `minimal`, `makepkg-git`, `build-installers`, and `full` alike. Also drop the now-stale comment explaining why `ucrt64` only had a `full` row. Assisted-by: Opus 4.7 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent 3a2084d commit 3cd3134

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

.github/workflows/test.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,15 @@ jobs:
4545
- architecture: x86_64
4646
flavor: minimal
4747
mingw_prefix: /mingw64
48-
# `ucrt64` is wired up end-to-end only for `flavor: full` at
49-
# this point (the subset flavors depend on follow-up work in
50-
# `build-extra` and the `ci-artifacts` pipeline of
51-
# `git-sdk-64`), so that is the one combination we can
52-
# meaningfully exercise on every PR.
48+
- architecture: ucrt64
49+
flavor: minimal
50+
mingw_prefix: /ucrt64
51+
- architecture: ucrt64
52+
flavor: makepkg-git
53+
mingw_prefix: /ucrt64
54+
- architecture: ucrt64
55+
flavor: build-installers
56+
mingw_prefix: /ucrt64
5357
- architecture: ucrt64
5458
flavor: full
5559
mingw_prefix: /ucrt64

0 commit comments

Comments
 (0)