Skip to content

Commit 9b70cae

Browse files
committed
matrix.yml: exercise architecture: ucrt64 with flavor: full
The manually-triggered `test all artifact flavors` workflow is the closest thing this repository has to an end-to-end smoke test that actually downloads an SDK and runs in-place. Without an entry for the new `ucrt64` axis it would silently keep verifying only the MINGW64 and MINGW32 paths, leaving regressions on the UCRT64 path to surface only in consumer repositories. Add a single `flavor: full, architecture: ucrt64` row via `include`, because that is the only combination wired up end-to-end at this point: the subset flavors still depend on `please.sh create-sdk-artifact` in `build-extra` learning `--architecture=ucrt64` and on a UCRT64 asset appearing in the `ci-artifacts` release of `git-sdk-64`, both tracked in git-for-windows/git-sdk-64#117 (comment). The build-installer step keys off `matrix.flavor == 'build-installers'` and is therefore skipped for the new row, which is exactly what we want. Assisted-by: Opus 4.7 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent 81a4ba7 commit 9b70cae

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

.github/workflows/matrix.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,13 @@ jobs:
1515
architecture: i686
1616
- flavor: makepkg-git
1717
architecture: i686
18+
# `ucrt64` is wired up end-to-end only for `flavor: full`; the
19+
# subset flavors depend on follow-up work in `build-extra` and
20+
# the `ci-artifacts` pipeline of `git-sdk-64`. Add the one
21+
# combination we can meaningfully exercise.
22+
include:
23+
- flavor: full
24+
architecture: ucrt64
1825
steps:
1926
- uses: actions/checkout@v6
2027
- name: run in-place

0 commit comments

Comments
 (0)