Skip to content

Commit f94bc2c

Browse files
committed
AGENTS.md: extend the architecture matrix with ucrt64
Now that the preceding commits have actually taught the Action about the `ucrt64` axis, document it in AGENTS.md so the institutional description there matches the code. Add a row to the architecture table covering repository, MSYSTEM, mingw bin path, and current limitations, plus a follow-up paragraph that points at git-for-windows/git-sdk-64#117 and git-for-windows/git-sdk-64#117 (comment) for the larger migration context. Mention in the relationship section that `git-sdk-64` now carries the extra long-lived `ucrt64` branch and that no UCRT64 asset exists in the `ci-artifacts` release, which is why the fast path is forcibly suppressed for that axis. Assisted-by: Opus 4.7 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent 7cab80d commit f94bc2c

1 file changed

Lines changed: 26 additions & 8 deletions

File tree

AGENTS.md

Lines changed: 26 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -112,20 +112,38 @@ The Action supports four flavors of the SDK:
112112
The `architecture` input drives both the underlying `git-sdk-*` repo
113113
and the `MSYSTEM` / bin-path layout inside the SDK:
114114

115-
| `architecture` | repo | MSYSTEM | mingw bin path | notes |
116-
| -------------- | --------------- | ------------ | ----------------- | ---------------------------------------------- |
117-
| `i686` | `git-sdk-32` | `MINGW32` | `/mingw32/bin` | only `build-installers` and `full` |
118-
| `x86_64` | `git-sdk-64` | `MINGW64` | `/mingw64/bin` | the default; fast path available for `minimal` |
119-
| `aarch64` | `git-sdk-arm64` | `CLANGARM64` | `/clangarm64/bin` | only `full` for now |
115+
| `architecture` | repo | MSYSTEM | mingw bin path | notes |
116+
| -------------- | --------------- | ------------ | ----------------- | -------------------------------------------------------------------------------------- |
117+
| `i686` | `git-sdk-32` | `MINGW32` | `/mingw32/bin` | only `build-installers` and `full` |
118+
| `x86_64` | `git-sdk-64` | `MINGW64` | `/mingw64/bin` | the default; fast path available for `minimal` |
119+
| `aarch64` | `git-sdk-arm64` | `CLANGARM64` | `/clangarm64/bin` | only `full` for now |
120+
| `ucrt64` | `git-sdk-64` | `UCRT64` | `/ucrt64/bin` | UCRT64 migration; cloned from the `ucrt64` branch of `git-sdk-64`; only `full` for now |
121+
122+
The `ucrt64` axis is part of the larger UCRT64 migration tracked in
123+
https://github.com/git-for-windows/git-sdk-64/pull/117 and its
124+
follow-up comment
125+
https://github.com/git-for-windows/git-sdk-64/pull/117#issuecomment-4642726384.
126+
It shares the `git-sdk-64` repository with `x86_64` but is materialised
127+
from a different long-lived branch, so caches and on-disk directories
128+
must stay distinct (the artifact name is `git-sdk-ucrt64-<flavor>`
129+
rather than `git-sdk-64-<flavor>`). The `ci-artifacts` release of
130+
`git-sdk-64` contains no UCRT64 asset, so the CI-artifacts fast path
131+
is forcibly skipped for this axis; every flavor takes the
132+
`getViaGit` path. `build-extra`'s `please.sh create-sdk-artifact` does
133+
not yet understand `--architecture=ucrt64` either, so right now only
134+
`flavor: full` (which goes straight through `git worktree add`)
135+
produces a working SDK. The non-`full` flavors will start working once
136+
`build-extra` and the `ci-artifacts` pipeline catch up.
120137

121138
## Relationship to other Git for Windows repositories
122139

123140
- [git-for-windows/git-sdk-64](https://github.com/git-for-windows/git-sdk-64),
124141
[git-sdk-32](https://github.com/git-for-windows/git-sdk-32),
125142
[git-sdk-arm64](https://github.com/git-for-windows/git-sdk-arm64) --
126-
the bare-repo SDKs themselves. Their `main` branch is what
127-
`getViaGit` clones; their `ci-artifacts` release is what
128-
`getViaCIArtifacts` downloads.
143+
the bare-repo SDKs themselves. Their `main` branch (and, for
144+
`git-sdk-64`, the `ucrt64` branch) is what `getViaGit` clones;
145+
their `ci-artifacts` release is what `getViaCIArtifacts` downloads
146+
(no UCRT64 asset there today).
129147
- [git-for-windows/build-extra](https://github.com/git-for-windows/build-extra)
130148
-- provides `please.sh create-sdk-artifact`, used by `getViaGit` to
131149
carve subset flavors (`minimal`, `makepkg-git`, `build-installers`)

0 commit comments

Comments
 (0)