refactor: SlackDeadLetterMessageListener가 처리중 에러가 발생 할 경우, 로그를 남기도록 수정한다

Author: devxb

src/main/kotlin/org/gitanimals/notification/app/SlackDeadLetterMessageListener.kt

@@ -6,6 +6,7 @@ import org.gitanimals.notification.app.event.DeadLetterEvent
 import org.gitanimals.notification.domain.Notification
 import org.gitanimals.notification.domain.Notification.ActionRequest
 import org.gitanimals.notification.domain.Notification.ActionRequest.Style.PRIMARY
+import org.slf4j.LoggerFactory
 import org.springframework.beans.factory.annotation.Qualifier
 import org.springframework.beans.factory.annotation.Value
 import org.springframework.data.redis.connection.Message
@@ -18,7 +19,9 @@ class SlackDeadLetterMessageListener(
     private val objectMapper: ObjectMapper,
     @Qualifier("gitAnimalsDeadLetterSlackNotification") private val notification: Notification,
     @Value("\${relay.approve.token}") private val approveToken: String,
-): TraceableMessageListener(redisTemplate, objectMapper) {
+) : TraceableMessageListener(redisTemplate, objectMapper) {
+
+    private val logger = LoggerFactory.getLogger(this::class.simpleName)
 
     override fun onMessage(message: Message) {
         runCatching {
@@ -51,6 +54,8 @@ class SlackDeadLetterMessageListener(
                     )
                 ),
             )
+        }.onFailure {
+            logger.error("Fail to notify dead letter. message: $message", it)
         }
     }
 }

src/main/kotlin/org/gitanimals/notification/app/event/DeadLetterEvent.kt

@@ -1,9 +1,10 @@
 package org.gitanimals.notification.app.event
 
-import org.rooftop.netx.api.SagaEvent
-
 data class DeadLetterEvent(
     val traceId: String,
     val deadLetterId: String,
-    val sagaEvent: SagaEvent,
+    val sagaId: String,
+    val nodeName: String,
+    val group: String,
+    val deadLetter: String,
 )

src/main/kotlin/org/gitanimals/supports/deadletter/DeadLetterEvent.kt

@@ -4,13 +4,15 @@ import org.gitanimals.core.IdGenerator
 import org.gitanimals.core.filter.MDCFilter
 import org.gitanimals.core.redis.AsyncRedisPubSubEvent
 import org.gitanimals.core.redis.RedisPubSubChannel.DEAD_LETTER_OCCURRED
-import org.rooftop.netx.api.SagaEvent
 import org.slf4j.MDC
 
 data class DeadLetterEvent(
-    private val deadLetterId: String,
-    private val sagaEvent: SagaEvent
-): AsyncRedisPubSubEvent(
+    val deadLetterId: String,
+    val sagaId: String,
+    val nodeName: String,
+    val group: String,
+    val deadLetter: String,
+) : AsyncRedisPubSubEvent(
     traceId = runCatching { MDC.get(MDCFilter.TRACE_ID) }
         .getOrElse { IdGenerator.generate().toString() },
     channel = DEAD_LETTER_OCCURRED,

src/main/kotlin/org/gitanimals/supports/deadletter/DeadLetterEventPublisher.kt

@@ -17,7 +17,10 @@ class DeadLetterEventPublisher(
             applicationEventPublisher.publishEvent(
                 DeadLetterEvent(
                     deadLetterId = deadLetterId,
-                    sagaEvent = sagaEvent,
+                    sagaId = sagaEvent.id,
+                    group = sagaEvent.group,
+                    nodeName = sagaEvent.nodeName,
+                    deadLetter = sagaEvent.decodeEvent(String::class),
                 )
             )
         }.also {