perf: RateLimiter의 토큰량이 충분할때는 contribution을 즉시 업데이트 하도록 수정한다

Author: devxb

src/main/kotlin/org/gitanimals/core/ratelimit/RateLimitable.kt

@@ -8,6 +8,8 @@ interface RateLimitable {
 
     fun <T> acquire(limitPercent: Double = 0.0, action: suspend (RateLimit?) -> T): T
 
+    fun findRateLimit(): RateLimit?
+
     fun update(rateLimit: RateLimit)
 
     data class RateLimit(

src/main/kotlin/org/gitanimals/render/infra/VisitedEventListener.kt

@@ -2,6 +2,7 @@ package org.gitanimals.render.infra
 
 import org.gitanimals.core.IdGenerator
 import org.gitanimals.core.filter.MDCFilter.Companion.TRACE_ID
+import org.gitanimals.core.ratelimit.RateLimitable
 import org.gitanimals.render.app.ContributionApi
 import org.gitanimals.render.app.IdentityApi
 import org.gitanimals.render.domain.UserService
@@ -10,6 +11,7 @@ import org.rooftop.netx.api.*
 import org.rooftop.netx.meta.SagaHandler
 import org.slf4j.LoggerFactory
 import org.slf4j.MDC
+import org.springframework.beans.factory.annotation.Qualifier
 import org.springframework.context.event.EventListener
 import org.springframework.dao.CannotAcquireLockException
 import org.springframework.scheduling.annotation.Async
@@ -21,6 +23,7 @@ class VisitedEventListener(
     private val userService: UserService,
     private val contributionApi: ContributionApi,
     private val identityApi: IdentityApi,
+    @Qualifier("inmemoryGithubRateLimiter") private val rateLimiter: RateLimitable,
 ) {
 
     private val logger = LoggerFactory.getLogger(this::class.simpleName)
@@ -35,8 +38,10 @@ class VisitedEventListener(
 
             logger.info("[VisitedEventListener] Increase visit to user. username: \"$username\"")
 
-            if (userService.isContributionUpdatedLongAgo(username).not()) {
-                return
+            rateLimiter.findRateLimit()?.let { rateLimit ->
+                if (rateLimit.getRemainPercentage() <= 50.0 && userService.isContributionUpdatedLongAgo(username).not()) {
+                    return
+                }
             }
 
             val currentYear = ZonedDateTime.now(ZoneId.of("UTC")).year

src/main/kotlin/org/gitanimals/supports/ratelimit/InmemoryGithubRateLimiter.kt

@@ -70,21 +70,23 @@ class InmemoryGithubRateLimiter(
         }
     }
 
-    override fun update(rateLimitable: RateLimitable.RateLimit) {
+    override fun findRateLimit(): RateLimitable.RateLimit? = rateLimit
+
+    override fun update(rateLimit: RateLimitable.RateLimit) {
         synchronized(lock) {
             this.rateLimit?.let {
-                if (it.requestedAt <= rateLimitable.requestedAt) {
-                    this.rateLimit = rateLimitable
+                if (it.requestedAt <= rateLimit.requestedAt) {
+                    this.rateLimit = rateLimit
                 }
             } ?: run {
-                this.rateLimit = rateLimitable
+                this.rateLimit = rateLimit
             }
-            if (rateLimitable.getRemainPercentage() < 20.0) {
+            if (rateLimit.getRemainPercentage() < 20.0) {
                 val message = """
                     :warning: Warning! 
                     Remaining token quota is below 20%.
                     ---
-                    $rateLimitable
+                    $rateLimit
                 """.trimIndent()
 
                 slackSender.send(githubTokenChannel, message)