Warning if removes a non-exists plugin

Author: git-hulk

cmd/plugin.go

@@ -3,6 +3,7 @@ package cmd
 import (
 	"fmt"
 	"os"
+	"path/filepath"
 	"sort"
 	"strings"
 
@@ -253,13 +254,18 @@ var pluginUninstallCmd = &cobra.Command{
 		)
 
 		for _, name := range names {
+			entry, exists := manifest.Get(name)
+			if !exists && !managedPluginBinaryExists(name) {
+				terminal.Warningf("Plugin %q is not installed; skipping.", name)
+				continue
+			}
+
 			spinner := uicli.NewSpinner().
 				WithStyle(uicli.SpinnerDots).
 				WithColor(uicli.CyanColor).
 				WithMessage(fmt.Sprintf("Removing plugin %q...", name)).
 				Start()
 
-			entry, _ := manifest.Get(name)
 			inst, err := installer.FromManifest(entry)
 			if err != nil {
 				// If we can't determine the installer type, just remove the binary directly.
@@ -490,6 +496,20 @@ func uniquePluginNames(args []string) []string {
 	return names
 }
 
+func managedPluginBinaryExists(name string) bool {
+	dir, err := plugin.PluginBinDir()
+	if err != nil {
+		return false
+	}
+
+	path := filepath.Join(dir, plugin.BinPrefix+name)
+	info, err := os.Stat(path)
+	if err != nil {
+		return false
+	}
+	return !info.IsDir()
+}
+
 func ensureInstallNameAvailable(manifest *plugin.Manifest, name string) error {
 	if _, exists := manifest.Get(name); exists {
 		return fmt.Errorf("plugin %q already exists; use \"clime plugin update %s\" or uninstall it first", name, name)

cmd/plugin_uninstall_test.go

@@ -1,6 +1,9 @@
 package cmd
 
-import "testing"
+import (
+	"strings"
+	"testing"
+)
 
 func TestUniquePluginNames(t *testing.T) {
 	t.Parallel()
@@ -37,3 +40,20 @@ func TestPluginUninstallArgsAllowsMultiple(t *testing.T) {
 		t.Fatal("zero args should fail")
 	}
 }
+
+func TestPluginUninstallWarnsWhenPluginDoesNotExist(t *testing.T) {
+	t.Setenv("HOME", t.TempDir())
+
+	output := captureStdout(t, func() {
+		if err := pluginUninstallCmd.RunE(pluginUninstallCmd, []string{"missing-plugin"}); err != nil {
+			t.Fatalf("pluginUninstallCmd.RunE() error = %v", err)
+		}
+	})
+
+	if !strings.Contains(output, `Plugin "missing-plugin" is not installed; skipping.`) {
+		t.Fatalf("stdout = %q, want missing-plugin warning", output)
+	}
+	if strings.Contains(output, `Removed plugin "missing-plugin"`) {
+		t.Fatalf("stdout = %q, should not report plugin removal", output)
+	}
+}