Porting to Godot 4

[abitrolly]

The godot4 branch is a behind main by 10 commits. Are there any plans to rebase and revive it?

What are the main obstacles to make oh-my-git run on Godot 4?

[halfluke]

Hi — I’ve been working on a Godot 4 port on my fork and wanted to share it here in case it helps anyone else on this issue, without necessarily opening a big upstream PR.

Fork / branch: https://github.com/halfluke/oh-my-git/tree/godot4

Godot version: 4.6.2 (project targets 4.6; tested with the official 4.6.2 stable build)

Status (on my side): The branch is in a state I consider fully playable for normal use: core Git levels, sandbox, level select, save/progress, and the extra “Beyond Git” reading chapters (GitHub / GitLab / Gitea / Bitbucket / Azure DevOps) with prev/next navigation through that trail. Automated tests pass in CI (Test workflow on push), and I’ve been able to build/export locally as well.

Roughly what’s in there compared to the old upstream godot4 branch:

Continued migration from the earlier port work on this repo’s godot4 branch
Godot 4 scene/script fixes (file browser, shell, level loading, audio bus handling, etc.)
Headless test runner + CI updates for Godot 4.6
Additional platform-theory content and related UX (reset progress, title screen flow, etc.)
I’m not asking for a merge or review burden on maintainers — the upstream README still describes Godot 3 and I know large ports are painful to review, especially with .tscn churn. I mainly wanted to leave a pointer here for anyone blocked on Godot 3 who wants a working Godot 4 line to try or cherry-pick from.

If it’s useful, I can answer specific questions about what broke during the port or how particular pieces were fixed. Otherwise, hopefully the branch is a helpful reference for others following this issue.

[abitrolly]

@halfluke thanks for the heads up. I think it worth documenting things where porting from Godot 3 didn't go well. Sounds like a good reference for Godot forum to transform into official migration docs. I remember there were some issues with missing IDs, but that was ages ago.

[halfluke]

Thanks — agreed that documenting where 3→4 hurt would be useful. On my fork (godot4, Godot 4.6.2) the problems that actually showed up in play weren’t mostly missing scene UIDs; the two that matched the old upstream godot4 branch were terminal input dying after commands and a black rectangle over the top-left when long output opened the pager. Below is a commit-oriented map in case it helps forum/wiki material.

---

1. Terminal input stops working

Symptom: after a card or typed command, the line edit stayed dead — input.editable never came back.

Cause: send_command() sets input.editable = false, then waits on the shell. On the old tree (5ff4ca6) that was run_async_web() + await cmd.done, but the worker could emit done before the await was connected, so command_done() never ran.

Fix chain:

• a8dc200 — temporary synchronous await shell.run() so command_done() always runs.
• ea00921 — shell.gd: worker no longer emits done from the thread; call_deferred("_complete_async_command", …) on the Shell node, then _emit_done() on the main thread.
• 0fe42e4 — restore run_async() + await shell_cmd.done + wait_to_finish(), finish UI with call_deferred("command_done", …); commit cards use -m [string] + input dialog instead of blocking on fake-editor before the terminal runs; command_done guards is_inside_tree() and null audio nodes.

---

2. Black square top-left (long output / pager)

Symptom: when command output is longer than about 1000 characters, the game opens a separate viewer. On the old port that showed a black box in the top-left instead of a proper centered window.

Cause: Godot 4 uses a Window node for the pager (not the old Popup API). The ported scene still had:

• layout_mode = 0 on the terminal Rows / Output nodes (broken anchors after 3→4)
• a bare Pager window with no size or position
• a call to popup() instead of popup_centered()

The black StyleBoxFlat from the in-terminal RichTextLabel bled through, and the empty Window child did not fill the viewport correctly.

Fix: 9d26f64 in terminal.tscn / terminal.gd:

• re-anchor terminal output (layout_mode = 1, full rect)
• configure the pager window (title, fixed size, hidden on ready)
• use popup_centered() and put the full "$ command\noutput" text in the pager label
• on close_requested, hide the pager and call input.grab_focus() so typing works again

---

3. Migration blockers — a8dc200

First “game actually runs” commit after upstream godot4:

• Level discovery: replace broken list_dir_begin() / get_next() loops with DirAccess.get_directories() (levels.gd) and get_files() (chapter.gd) — without this, level lists were empty.
• Git check: re-enable command -v git in game.gd (was wrapped in if false:); route to no_git.tscn when missing; restore copying fake-editor / hint into the game env. better_shell.gd: treat Linux as bash, not only "X11".
• File browser vs editor: file_browser.close() only when text_edit.visible; close_all_editors() checks has_method("close").
• Misc: drop _process() hack forcing $Rows.size.y = 1064; level-load timer one_shot = true.

---

4. Startup & scene format — f429ec0

• Deferred scene-tree work: title.gd → call_deferred scene change to level select; cards.gd → deferred _finish_draw; level_select.gd → await process_frame after clearing; repository.gd → call_deferred("queue_free") on graph/drop nodes during updates.
• Line splitting: helpers.split_lines() (split("\n", false) + trim trailing empty line) used for shell output in file browser, repository git graph, terminal tab-completion — fixes stray empty rows / broken graph parsing on Godot 4 typed arrays.
• Scene resave: key .tscn files → format=3 with Godot 4 container layout (cards, file browser, repository, level select, etc.).

---

5. Further scene migration

• ba4e8ec — initial Godot 4.1 upgrade.
• 8bc563c — remaining format-2 scenes → format 3 + SFX bus wiring.

---

6. Audio buses (silent SFX)

• 293eebf — reference default_bus_layout.tres from project.godot.
• 3542e87 — UID on the resource + uid:// in project settings (4.3 persistence).
• 0c9e739 — on 4.6 the editor often strips [audio] from project.godot on quit; runtime fallback in game.gd loads the layout if the SFX bus is missing.

---

Terminal / threading (commits in order)

Commit	What it fixed
ea00921	Shell done signal on main thread (call_deferred join + emit).
0fe42e4	Commit-card freeze; threaded terminal restored safely.
9d26f64	Pager layout / close behavior for long output.

---

No standalone migration doc yet — this thread + those commits are the notes. Happy to expand any section (especially thread/done and Window vs Popup pager) or compare with the missing-ID issues you saw on earlier 4.x. Branch is a playable reference fork, not a proposal to upstream the whole port.