Implement hands-on T8L1/hp-remote-branch-push#229
Conversation
|
Hi @jiaxinnns, thank you for your contribution! 🎉 This PR comes from your fork Before you request for a review, please ensure that you have tested your changes locally! Important The previously recommended way of using Please read the following instructions for the latest instructions. PrerequisitesEnsure that you have the Testing stepsIf you already have a local Git-Mastery root to test, you can skip the following step. Create a Git-Mastery root locally: gitmastery setupNavigate into the Git-Mastery root (defaults to cd gitmastery-exercises/Edit the {
# other fields...
"exercises_source": {
"username": "jiaxinnns",
"repository": "exercises",
"branch": "feature/remote-branch-push",
}
}Then, you can use the gitmastery download <your new change>
gitmastery verifyChecklist
Important To any reviewers of this pull request, please use the same instructions above to test the changes. |
jovnc
left a comment
There was a problem hiding this comment.
LGTM just some minor nits!
jovnc
left a comment
There was a problem hiding this comment.
LGTM
Just one potential limitation to take note for us, when we clone a repository, it doesn't copy over all remote branches to local branches, ie. when you do a git branch, only main will appear. But all branches (local and remote) will appear when we do git branch -a.
However, we can still switch/checkout to the remote branch, and it will automatically track the local branch to the remote branch for us.
Exercise Review
Exercise Discussion
Fixes #186
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?git-autograder?app?