Implement hp-remote-branch-pull

[desmondwong1215]

Exercise Review

Exercise Discussion

#187

Checklist

• If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
• Have you written unit tests using repo-smith to validate the exercise grading scheme?
• Have you tested your changes using the instructions posted?
• Have you verified that this exercise does not already exist or is not currently in review?
• Did you introduce a new grading mechanism that should belong to git-autograder?
• Did you introduce a new dependency that should belong to app?

[github-actions]

Hi @desmondwong1215, thank you for your contribution! 🎉

This PR comes from your fork desmondwong1215/exercises on branch hp-remote-branch-pull.

Before you request for a review, please ensure that you have tested your changes locally!

Important

The previously recommended way of using ./test-download.py is no longer the best way to test your changes locally.

Please read the following instructions for the latest instructions.

Prerequisites

Ensure that you have the gitmastery app installed locally (instructions)

Testing steps

If you already have a local Git-Mastery root to test, you can skip the following step.

Create a Git-Mastery root locally:

gitmastery setup

Navigate into the Git-Mastery root (defaults to gitmastery-exercises/):

cd gitmastery-exercises/

Edit the .gitmastery.json configuration file. You need to set the following values under the exercises_source key.

{
    # other fields...
    "exercises_source": {
        "username": "desmondwong1215",
        "repository": "exercises",
        "branch": "hp-remote-branch-pull",
    }
}

Then, you can use the gitmastery app to download and verify your changes locally.

gitmastery download <your new change>
gitmastery verify

Checklist

• (For exercises and hands-ons) I have verified that the downloading behavior works
• (For exercises only) I have verified that the verification behavior is accurate

Important

To any reviewers of this pull request, please use the same instructions above to test the changes.

[jovnc]

Thanks for working on this! Some changes are needed as I think there might be some issues with the issue itself.

[jovnc]

I just merged a PR from @jiaxinnns that uses the same util function, you can rebase your PR against the main branch and use that instead.

[jovnc]

No need for this change, refer to below.

[jovnc]

No need to set upstream here. Seems like it was a mistake, as there's no need for git push -u

Below is the expected branches (no upstream here):

[desmondwong1215]

I think that the reason git push -u is used in the issue is because step 2 in the hands-on of T8L1 is git push origin -u hiring.

Should we just use git push origin hiring instead in this hands-on?

[jovnc]

Yup that's right, we should use git push origin hiring instead so it won't set the upstream remote for us. This way, we can get the expected git branch -a output.

[VikramGoyal23]

LGTM!