script/update-docs.rb: set {build_dir} correctly#1993
Merged
dscho merged 1 commit intogit:gh-pagesfrom Apr 14, 2025
Merged
Conversation
Some files use the `include::` directive to include content from another
file into the current document. In Git's commit
9219325be74 (Documentation: allow sourcing generated includes from
separate dir, 2024-12-06) the use of {build_dir} was introduced. In
d51c252 (update-docs: accommodate for changes in Git v2.48.0,
2025-01-22) these issues were addressed, but when {build_dir} was used
in a file in a subdir in Documentation/ then this still gets messed up.
Replace {build_dir} by 'Documentation' so including files in {build_dir}
works correctly everywhere.
Signed-off-by: Toon Claes <toon@iotcl.com>
dscho
approved these changes
Apr 14, 2025
Member
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
❤️ Thank you for fixing my bug!
Collaborator
Author
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Some files use the
include::directive to include content from anotherfile into the current document. In Git's commit
9219325be74 (Documentation: allow sourcing generated includes from
separate dir, 2024-12-06) the use of {build_dir} was introduced. In
d51c252 (update-docs: accommodate for changes in Git v2.48.0,
2025-01-22) these issues were addressed, but when {build_dir} was used
in a file in a subdir in Documentation/ then this still gets messed up.
Replace {build_dir} by 'Documentation' so including files in {build_dir}
works correctly everywhere.
Fixes #1982