feat: removed scroll to top button#2089
Conversation
| </div> | ||
| </footer> | ||
| <a href="#top" class="no-js scrollToTop" id="scrollToTop" data-label="Scroll to top"> | ||
| <img src="{{ relURL "images/icons/chevron-up@2x.png" }}" width="20" height="20" alt="scroll-to-top"/> |
There was a problem hiding this comment.
Shouldn't the chevron-up PNGs be deleted at the same time?
There was a problem hiding this comment.
sure, but that's in my .gitignore i guess how can I push it?
There was a problem hiding this comment.
I was talking about https://github.com/git/git-scm.com/blob/gh-pages/static/images/icons/chevron-up.png and https://github.com/git/git-scm.com/blob/gh-pages/static/images/icons/chevron-up@2x.png, which are tracked (and therefore not in .gitignore, I don't think?)...
There was a problem hiding this comment.
oh there's the same in public/ as well
There was a problem hiding this comment.
I guess if I remove the pngs from static, then they would not be generated in the public/ folder
so the correct course would be to infact remove the pngs from static/
if the above is correct do give me the go ahead, I'll push these changes
There was a problem hiding this comment.
Yes, public/ contains the output of Hugo. Parts of that tree are verbatim copies from files that live in static/.
There was a problem hiding this comment.
(And to make sure that this is clear: removing the files from static/ and then re-running Hugo will not remove the files from public/; You'd have to remove the public/ folder completely and then run Hugo again for that to happen.)
There was a problem hiding this comment.
great, thanks for confirming
2 participants
Feature: removed scroll to top button
As we are currently refreshing the website, per the discussion in issue #2067 , the consensus is to try a "Just Do It, and Revert It If Necessary" approach. Therefore, this PR removes the scroll-to-top button. If this change triggers a negative response from users, it will be reverted and we will pretend it never happened.
Removed the Scroll to top button in its entirety
This includes its css, the element itself and all references to it.
cc: @To1ne @dscho