Skip to content

Commit 15a2812

Browse files
committed
Add missing ref composition
1 parent ca1eec0 commit 15a2812

3 files changed

Lines changed: 8 additions & 2 deletions

File tree

apps/lite/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
"@atlaskit/pragmatic-drag-and-drop": "^1.7.9",
3939
"@atlaskit/pragmatic-drag-and-drop-hitbox": "^1.1.0",
4040
"@base-ui/react": "^1.4.0",
41+
"@base-ui/utils": "^0.2.7",
4142
"@gitbutler/but-sdk": "workspace:*",
4243
"@pierre/diffs": "^1.1.3",
4344
"@reduxjs/toolkit": "catalog:redux",

apps/lite/ui/src/routes/project/$id/workspace/route.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ import {
6464
} from "#ui/native-menu.ts";
6565
import uiStyles from "#ui/ui.module.css";
6666
import { mergeProps, Tooltip, useRender } from "@base-ui/react";
67+
import { useMergedRefs } from "@base-ui/utils/useMergedRefs";
6768
import {
6869
AbsorptionTarget,
6970
Commit,
@@ -265,8 +266,9 @@ const ItemRow: FC<
265266
{
266267
isSelected?: boolean;
267268
} & ComponentProps<"div">
268-
> = ({ className, isSelected, ...props }) => {
269+
> = ({ className, isSelected, ref: refProp, ...props }) => {
269270
const rowRef = useRef<HTMLDivElement | null>(null);
271+
const mergedRef = useMergedRefs(rowRef, refProp);
270272

271273
useLayoutEffect(() => {
272274
if (!isSelected) return;
@@ -279,7 +281,7 @@ const ItemRow: FC<
279281
return (
280282
<div
281283
{...props}
282-
ref={rowRef}
284+
ref={mergedRef}
283285
className={classes(className, styles.itemRow, isSelected && styles.itemRowSelected)}
284286
/>
285287
);

pnpm-lock.yaml

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)