Merge pull request #13915 from gitbutlerapp/dp-fix-build

Fix misc lint issues

Author: davidpdrsn

Cargo.toml

@@ -323,6 +323,10 @@ uninlined_format_args = "deny"
 # This comes mostly from `thiserror` in `gix`, and it's going to be converted
 # to `Exn`, which will box erorrs and keep them small (much like `anyhow`).
 result_large_err = "allow"
+# This being `deny` is overly strict
+unnecessary_mut_passed = "warn"
+# This being `deny` is overly strict
+needless_borrow = "warn"
 
 [profile.release]
 # There are no overrides here as we optimise for fast release builds,

crates/but-server/src/irc.rs

@@ -256,7 +256,7 @@ pub async fn irc_start_working_files_broadcast(
 
     // Seed initial file list from the current worktree state.
     let initial_files = match but_ctx::Context::try_from(project_id.clone()) {
-        Ok(mut ctx) => match but_api::diff::changes_in_worktree(&mut ctx) {
+        Ok(ctx) => match but_api::diff::changes_in_worktree(&ctx) {
             Ok(changes) => changes
                 .worktree_changes
                 .changes

crates/but/src/lib.rs

@@ -265,7 +265,7 @@ async fn match_subcommand(
     #[cfg(feature = "agentlog")]
     let cmd = match cmd {
         Subcommands::AgentLog { cmd } => {
-            return run_agentlog_command(&args.current_dir, cmd, out);
+            return Ok(run_agentlog_command(&args.current_dir, cmd, out)?);
         }
         cmd => cmd,
     };

crates/gitbutler-tauri/src/irc.rs

@@ -374,7 +374,7 @@ pub async fn irc_start_working_files_broadcast(
 
     // Seed initial file list from the current worktree state.
     let initial_files = match but_ctx::Context::try_from(project_id.clone()) {
-        Ok(mut ctx) => match but_api::diff::changes_in_worktree(&mut ctx) {
+        Ok(ctx) => match but_api::diff::changes_in_worktree(&ctx) {
             Ok(changes) => changes
                 .worktree_changes
                 .changes