fix: remove ability to set default_pick_mode on graph editor

Review pointed out that setting PickMode::Force as the default pick mode
for the editor is exceptionally unlikely to be useful, as that would
forcibly cherry-pick potentially thousands of resolved commits in the
graph.

Author: slarse

crates/but-rebase/src/graph_rebase/creation.rs

@@ -7,22 +7,19 @@ use petgraph::{Direction, visit::EdgeRef as _};
 
 use crate::graph_rebase::{
     Checkout, Edge, Editor, Pick, RevisionHistory, Selector, Step, StepGraph, StepGraphIndex,
-    SuccessfulRebase, cherry_pick::PickMode, util,
+    SuccessfulRebase, util,
 };
 
 #[derive(Clone, Copy)]
 /// Options for the editor.
 pub struct GraphEditorOptions {
-    /// Determines when picks are cherry-picked during a rebase.
-    pub default_pick_mode: PickMode,
-    /// Determines how resulting commits are signed.
+    /// Determines how cherry-picked commits are signed.
     pub default_sign_commit: SignCommit,
 }
 
 impl Default for GraphEditorOptions {
     fn default() -> Self {
         Self {
-            default_pick_mode: PickMode::IfChanged,
             default_sign_commit: SignCommit::IfSignCommitsEnabled,
         }
     }
@@ -120,7 +117,6 @@ impl<'ws, 'meta, M: RefMetadata> Editor<'ws, 'meta, M> {
                         Pick::new_workspace_pick(commit.id)
                     } else {
                         let mut pick = Pick::new_pick(commit.id);
-                        pick.pick_mode = options.default_pick_mode;
                         pick.sign_commit = options.default_sign_commit;
                         pick
                     };

crates/but-rebase/tests/rebase/graph_rebase/signing_preferences.rs

@@ -202,7 +202,6 @@ fn force_picked_commit_with_sign_yes_is_signed_when_otherwise_unchanged() -> Res
         &mut *meta,
         &repo,
         &GraphEditorOptions {
-            default_pick_mode: PickMode::IfChanged,
             default_sign_commit: SignCommit::No,
         },
     )?;
@@ -270,7 +269,6 @@ fn force_picked_ancestor_does_not_sign_descendants_picked_with_sign_commit_no()
         &mut *meta,
         &repo,
         &GraphEditorOptions {
-            default_pick_mode: PickMode::IfChanged,
             default_sign_commit: SignCommit::No,
         },
     )?;
@@ -357,7 +355,6 @@ fn force_picked_ancestor_triggers_cascading_signatures_on_descendants_picked_wit
         &mut *meta,
         &repo,
         &GraphEditorOptions {
-            default_pick_mode: PickMode::IfChanged,
             default_sign_commit: SignCommit::Yes,
         },
     )?;
@@ -442,7 +439,6 @@ fn commit_picked_with_sign_if_enabled_is_not_signed_when_signing_config_is_disab
         &mut *meta,
         &repo,
         &GraphEditorOptions {
-            default_pick_mode: PickMode::IfChanged,
             default_sign_commit: SignCommit::IfSignCommitsEnabled,
         },
     )?;
@@ -510,7 +506,6 @@ fn parentless_commit_force_picked_with_sign_yes_is_signed() -> Result<()> {
         &mut *meta,
         &repo,
         &GraphEditorOptions {
-            default_pick_mode: PickMode::IfChanged,
             default_sign_commit: SignCommit::IfSignCommitsEnabled,
         },
     )?;