Error uploading an asset to github when creating a PR

[Andrej730]

Version

0.19.12

Operating System

Linux

Distribution Method

deb (Linux)

Describe the issue

When creating a new Github PR from GitButler UI, I was trying to upload a demo video for PR #13852, but it was resulting in the error below.
Relogin didn't helped. PR was successfully created using this login, so it might be some kind of permissions problem that GitButler is requesting when connecting client to Github.

Error: Login token expired. Please log in to GitButler again.

Console:

[Byron]

Thanks a lot for reporting.

And wow, I didn't even know you could upload files to the user interface 😅.

Maybe this was just an unlucky coincidence that the HTTP request failed with the error of the token expired, but then I would have expected it to be the GitHub token, and not the GitButler one.

gitbutler/apps/desktop/src/components/editor/MessageEditor.svelte

Lines 152 to 168 in dd0d666

	async function onDropFiles(files: FileList | undefined): Promise<DropFileResult[]> {
	if (files === undefined) return [];
	const uploads = Array.from(files)
	.filter(isAcceptedFileType)
	.map(async (file) => {
	const upload = await uploadsService.uploadFile(file);
	return { name: file.name, url: upload.url, isImage: upload.isImage };
	});
	const settled = await Promise.allSettled(uploads);
	const successful = settled.filter((result) => result.status === "fulfilled");
	const failed = settled.filter((result) => result.status === "rejected");
	if (failed.length > 0) {
	console.error("File upload failed", failed);
	showError("File upload failed", failed.map((result) => result.reason).join(", "));
	}

Maybe @mtsgrd has an intuition.