Skip to content

fix(ui): normalize button sizing and update icons#13118

Merged
PavelLaptev merged 5 commits intomasterfrom
update-icons
Apr 5, 2026
Merged

fix(ui): normalize button sizing and update icons#13118
PavelLaptev merged 5 commits intomasterfrom
update-icons

Conversation

@PavelLaptev
Copy link
Copy Markdown
Contributor

@PavelLaptev PavelLaptev commented Mar 31, 2026

Before:

image

After:

image

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
gitbutler-web Ignored Ignored Preview Apr 5, 2026 9:21pm

Request Review

@PavelLaptev PavelLaptev marked this pull request as draft March 31, 2026 19:44
@PavelLaptev PavelLaptev marked this pull request as ready for review April 5, 2026 20:49
Copilot AI review requested due to automatic review settings April 5, 2026 20:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates shared UI icon SVGs and adjusts button/icon sizing rules so icon buttons and tag-sized buttons render with more consistent dimensions across the UI.

Changes:

  • Updated several SVG icon definitions (stack-plus, push, push-all, branch-tick) to new stroke-based shapes.
  • Normalized Button icon sizing by deriving icon size from the button size prop and wiring it through all internal icon renders.
  • Tweaked a few desktop UI layout styles (sidebar square button padding, commit list item right padding, branch header icon size) to align with the updated button sizing.

Reviewed changes

Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/ui/src/lib/icons/svg/stack-plus.svg Replaced icon path to updated design.
packages/ui/src/lib/icons/svg/push.svg Simplified/updated push icon path.
packages/ui/src/lib/icons/svg/push-all.svg Updated push-all icon geometry and strokes.
packages/ui/src/lib/icons/svg/branch-tick.svg Switched to stroked branch/tick icon style.
packages/ui/src/lib/components/KebabButton.svelte Set explicit icon size for the minimal/hover kebab button.
packages/ui/src/lib/components/Button.svelte Derived icon size from size and adjusted size CSS variables/padding/gap.
apps/desktop/src/components/views/AppSidebar.svelte Removed padding inside sidebar square buttons for consistent sizing.
apps/desktop/src/components/commit/CommitListItem.svelte Slightly increased right padding to match new spacing.
apps/desktop/src/components/branch/BranchHeaderIcon.svelte Standardized branch header icon size to 14.

to match button styles for small sizes.
@PavelLaptev PavelLaptev merged commit 6171c41 into master Apr 5, 2026
37 checks passed
@PavelLaptev PavelLaptev deleted the update-icons branch April 5, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants