Skip to content

Feature/comment char#13847

Open
UeberTimei wants to merge 4 commits into
gitbutlerapp:masterfrom
UeberTimei:feature/commentChar
Open

Feature/comment char#13847
UeberTimei wants to merge 4 commits into
gitbutlerapp:masterfrom
UeberTimei:feature/commentChar

Conversation

@UeberTimei
Copy link
Copy Markdown

🧢 Changes

Adds full support for Git's core.commentChar configuration across the CLI, TUI, and editor workflows, including dynamic comment stripping and custom ignore markers.

☕️ Reasoning

Ensures GitButler correctly respects custom commit comment characters (such as ;) during commit, reword, and branch renaming operations instead of hardcoding #.

🎫 Affected issues

Fixes: #13845

Copy link
Copy Markdown
Contributor

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging this I think we should discuss whether we allow configuring it or use a different delimiter. See #13845 (comment)

@Byron Byron marked this pull request as draft May 16, 2026 21:58
@Byron
Copy link
Copy Markdown
Collaborator

Byron commented May 16, 2026

Thanks a lot for contributing.

Putting this to draft while it's being discussed

@UeberTimei UeberTimei marked this pull request as ready for review May 17, 2026 08:18
@UeberTimei UeberTimei force-pushed the feature/commentChar branch from 4374b05 to ab2df48 Compare May 18, 2026 15:22
@UeberTimei UeberTimei requested a review from davidpdrsn May 18, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

commentChar isn't working in git butler cli

3 participants