Use head_info rather than stacks or stack_details when possible#13904
Draft
Caleb-T-Owens wants to merge 2 commits into
Draft
Use head_info rather than stacks or stack_details when possible#13904Caleb-T-Owens wants to merge 2 commits into
head_info rather than stacks or stack_details when possible#13904Caleb-T-Owens wants to merge 2 commits into
Conversation
Caleb-T-Owens
force-pushed
the
caleb/use-head-info-rather-than-stacks
branch
from
4cbfd44 to
f7e416e
Compare
Caleb-T-Owens
changed the base branch from
master
to
caleb/head-info-has-gerrit-metadata
Caleb-T-Owens
force-pushed
the
caleb/use-head-info-rather-than-stacks
branch
from
f7e416e to
7a2e646
Compare
Caleb-T-Owens
force-pushed
the
caleb/head-info-has-gerrit-metadata
branch
from
cec2bc9 to
e27c1f1
Compare
We still need some usage of `stacks` for the branch listing page AFAIK, but using `head_info` for the main projection is a big help since it avoids the issues with some strange inconsistency issues between `stack_details` and `stacks`.
Caleb-T-Owens
force-pushed
the
caleb/head-info-has-gerrit-metadata
branch
from
e27c1f1 to
deaeac0
Compare
Caleb-T-Owens
force-pushed
the
caleb/use-head-info-rather-than-stacks
branch
from
bae9c5e to
56545d8
Compare
Contributor
|
@Caleb-T-Owens Smoke tests failed with That's not related to the code in this PR (see this comment) and probably a spurious error, but it's still worrying. My best guess is that it's the background sync interfering with the next command being executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still need some usage of
stacksfor the branch listing page AFAIK, but usinghead_infofor the main projection is a big help since it avoids the issues with some strange inconsistency issues betweenstack_detailsandstacks.