feat(cli)!: remove --json in favor of --format json#14061
Conversation
f2daa57 to
f7454d9
Compare
There was a problem hiding this comment.
Copilot encountered an error: Your billing is not configured or you have Copilot licenses from multiple standalone organizations or enterprises. To use premium requests, select a billing entity via the GitHub site, under Settings > Copilot > Features.
krlvi
left a comment
There was a problem hiding this comment.
This is fine. The agents are not using the --json flag but it is still useful for scripting.
Just dont forget to update the docs http://github.com/gitbutlerapp/gitbutler-docs
We shouldn't update the docs before release, should we? Updating docs should be automated but it should never happen before release unless we have an nightly docs subdomain or similar. Which we don't? |
change rewords --format flag to --fix-formatting fix tests using short -f fix skills and other things that mention --json fix remaining few tests fix tests passing --json
f7454d9 to
adb1126
Compare
|
I've opened gitbutlerapp/gitbutler-docs#198 which we can merge when making a new release. |
Removes the global
--jsonflag in favor of using--format json. That way, there is only one way to specify the format.@slarse and I think not having
--formatas a global flag is good since it might not make sense for all commands. Instead, the commands that support format should handle it specifically. This PR doesn't change that;--formatis still global, but we'll look into it later. But to move in that direction, I addedwhich can be
#[clap(flatten)]'ed into other arg structs later. Currently, it's just used in the top-levelArgstype.