Skip to content

Commit 301f08c

Browse files
committed
Merge branch 'mf/apply-p-no-atoi' into jch
"git apply -p<n>" parses <n> more carefully now. * mf/apply-p-no-atoi: SQUASH??? apply.c: fix -p argument parsing
2 parents eacb5c5 + 99f750d commit 301f08c

2 files changed

Lines changed: 40 additions & 1 deletion

File tree

apply.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4981,7 +4981,8 @@ static int apply_option_parse_p(const struct option *opt,
49814981

49824982
BUG_ON_OPT_NEG(unset);
49834983

4984-
state->p_value = atoi(arg);
4984+
if (strtol_i(arg, 10, &state->p_value) < 0 || state->p_value < 0)
4985+
die("<num> has to be a non-negative integer");
49854986
state->p_value_known = 1;
49864987
return 0;
49874988
}

t/t4120-apply-popt.sh

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,44 @@ test_expect_success setup '
2323
rmdir süb
2424
'
2525

26+
test_expect_success 'git apply -p 1 patch' '
27+
cat >patch <<-\EOF &&
28+
From 90ad11d5b2d437e82d4d992f72fb44c2227798b5 Mon Sep 17 00:00:00 2001
29+
From: Mroik <mroik@delayed.space>
30+
Date: Mon, 9 Mar 2026 23:25:00 +0100
31+
Subject: [PATCH] Test
32+
33+
---
34+
t/test/test | 0
35+
1 file changed, 0 insertions(+), 0 deletions(-)
36+
create mode 100644 t/test/test
37+
38+
diff --git a/t/test/test b/t/test/test
39+
new file mode 100644
40+
index 0000000000..e69de29bb2
41+
--
42+
2.53.0.851.ga537e3e6e9
43+
EOF
44+
test_when_finished "rm -rf t" &&
45+
git apply -p 1 patch &&
46+
test_path_is_dir t
47+
'
48+
49+
test_expect_success 'apply fails due to non-num -p' '
50+
test_when_finished "rm -rf t test" &&
51+
test_must_fail git apply -p malformed patch
52+
'
53+
54+
test_expect_success 'apply fails due to trailing non-digit in -p' '
55+
test_when_finished "rm -rf t test" &&
56+
test_must_fail git apply -p 2q patch
57+
'
58+
59+
test_expect_success 'apply fails due to negative number in -p' '
60+
test_when_finished "rm -rf t test patch" &&
61+
test_must_fail git apply -p -1 patch
62+
'
63+
2664
test_expect_success 'apply git diff with -p2' '
2765
cp file1.saved file1 &&
2866
git apply -p2 patch.file

0 commit comments

Comments
 (0)