Skip to content

Commit 3776e2b

Browse files
pks-tgitster
authored andcommitted
t1301: don't fail in case setfacl(1) doesn't exist or fails
In t1301 we're trying to remove any potentially-existing default ACLs that might exist on the transh directory by executing setfacl(1). According to 8ed0a74 (t1301-shared-repo.sh: don't let a default ACL interfere with the test, 2008-10-16), this is done because we play around with permissions and umasks in this test suite. The setfacl(1) binary may not exist on some systems though, even though tests ultimately still pass. This doesn't matter currently, but will cause the test to fail once we start running with `set -e`. Silence such failures by ignoring failures here. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 0f755c7 commit 3776e2b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

t/t1301-shared-repo.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ TEST_CREATE_REPO_NO_TEMPLATE=1
1212
. ./test-lib.sh
1313

1414
# Remove a default ACL from the test dir if possible.
15-
setfacl -k . 2>/dev/null
15+
setfacl -k . 2>/dev/null || true
1616

1717
# User must have read permissions to the repo -> failure on --shared=0400
1818
test_expect_success 'shared = 0400 (faulty permission u-w)' '

0 commit comments

Comments
 (0)