IConfig: move repo.owners to a better place

The `owners` array refers to a list of orgs/owners where the GitHub App
is installed, i.e. where GitGitGadget can operate.

Therefore, a much better place is `app.installedOn`.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

lib/ci-helper.ts

@@ -175,7 +175,7 @@ export class CIHelper {
             console.time("get open PR head commits");
             const openPRCommits = (
                 await Promise.all(
-                    this.config.repo.owners.map(async (repositoryOwner) => {
+                    this.config.app.installedOn.map(async (repositoryOwner) => {
                         return await this.github.getOpenPRs(repositoryOwner);
                     }),
                 )
@@ -256,7 +256,7 @@ export class CIHelper {
         const prCommentUrl = core.getInput("pr-comment-url");
         const [, owner, repo, prNumber, commentId] =
             prCommentUrl.match(/^https:\/\/github\.com\/([^/]+)\/([^/]+)\/pull\/(\d+)#issuecomment-(\d+)$/) || [];
-        if (!this.config.repo.owners.includes(owner) || repo !== this.config.repo.name) {
+        if (!this.config.app.installedOn.includes(owner) || repo !== this.config.repo.name) {
             throw new Error(`Invalid PR comment URL: ${prCommentUrl}`);
         }
         return { owner, repo, prNumber: parseInt(prNumber, 10), commentId: parseInt(commentId, 10) };
@@ -266,7 +266,7 @@ export class CIHelper {
         const prUrl = core.getInput("pr-url");
 
         const [, owner, repo, prNumber] = prUrl.match(/^https:\/\/github\.com\/([^/]+)\/([^/]+)\/pull\/(\d+)$/) || [];
-        if (!this.config.repo.owners.includes(owner) || repo !== this.config.repo.name) {
+        if (!this.config.app.installedOn.includes(owner) || repo !== this.config.repo.name) {
             throw new Error(`Invalid PR URL: ${prUrl}`);
         }
         return { owner, repo, prNumber: parseInt(prNumber, 10) };
@@ -1137,7 +1137,7 @@ export class CIHelper {
         const handledPRs = new Set<string>();
         const handledMessageIDs = new Set<string>();
 
-        for (const repositoryOwner of this.config.repo.owners) {
+        for (const repositoryOwner of this.config.app.installedOn) {
             const pullRequests = await this.github.getOpenPRs(repositoryOwner);
 
             for (const pr of pullRequests) {
@@ -1195,7 +1195,7 @@ export class CIHelper {
     private async getPRInfo(prKey: pullRequestKey): Promise<IPullRequestInfo> {
         const pr = await this.github.getPRInfo(prKey);
 
-        if (!this.config.repo.owners.includes(pr.baseOwner) || pr.baseRepo !== this.config.repo.name) {
+        if (!this.config.app.installedOn.includes(pr.baseOwner) || pr.baseRepo !== this.config.repo.name) {
             throw new Error(`Unsupported repository: ${pr.pullRequestURL}`);
         }
 

lib/gitgitgadget-config.ts

@@ -6,7 +6,6 @@ const defaultConfig: IConfig = {
         owner: "gitgitgadget",
         upstreamOwner: "git",
         testOwner: "dscho",
-        owners: ["gitgitgadget", "git", "dscho"],
         branches: ["maint", "seen"],
         closingBranches: ["maint", "master"],
         trackingBranches: ["maint", "seen", "master", "next"],
@@ -36,6 +35,7 @@ const defaultConfig: IConfig = {
         name: "gitgitgadget",
         displayName: "GitGitGadget",
         altname: "gitgitgadget-git",
+        installedOn: ["gitgitgadget", "git", "dscho"],
     },
     lint: {
         maxCommitsIgnore: ["https://github.com/gitgitgadget/git/pull/923"],

lib/project-config.ts

@@ -14,7 +14,6 @@ export interface IConfig {
         owner: string; // owner of repo holding the notes (tracking data)
         upstreamOwner: string; // owner of upstream ("base") repo
         testOwner?: string; // owner of the test repo (if any)
-        owners: string[]; // owners of clones being monitored (PR checking)
         branches: string[]; // remote branches to fetch - just use trackingBranches?
         closingBranches: string[]; // close if the pr is added to this branch
         trackingBranches: string[]; // comment if the pr is added to this branch
@@ -44,6 +43,7 @@ export interface IConfig {
         installationID: number;
         name: string;
         displayName: string; // name to use in comments to identify app
+        installedOn: string[]; // owners of clones being monitored (PR checking)
         altname: string | undefined; // is this even needed?
     };
     lint: {

tests-config/ci-helper.test.ts

@@ -17,7 +17,6 @@ const testConfig: IConfig = {
         name: "telescope",
         owner: "webb",
         upstreamOwner: "galileo",
-        owners: ["webb", "galileo"],
         branches: ["maint"],
         closingBranches: ["maint", "main"],
         trackingBranches: ["maint", "main", "hubble"],
@@ -41,7 +40,8 @@ const testConfig: IConfig = {
         installationID: 195971,
         name: "gitgitgadget",
         displayName: "BigScopes",
-        altname: "gitgitgadget-git"
+        altname: "gitgitgadget-git",
+        installedOn: ["webb", "galileo"],
     },
     lint: {
         maxCommitsIgnore: [],