ref-filter: drop unused parameters from email_atom_option_parser()

peff · gitster · commit 4d7de2cf6e4d · 2024-08-17T09:44:41.000-07:00
This code was extracted from person_email_atom_parser() in a3d2e83 (ref-filter: add mailmap support, 2023-09-25), but the part that was extracted doesn't care about the atom struct or the error strbuf. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/ref-filter.c b/ref-filter.c
@@ -742,8 +742,7 @@ static int person_name_atom_parser(struct ref_format *format UNUSED,
 	return 0;
 }
 
-static int email_atom_option_parser(struct used_atom *atom,
-				    const char **arg, struct strbuf *err)
+static int email_atom_option_parser(const char **arg)
 {
 	if (!*arg)
 		return EO_RAW;
@@ -761,7 +760,7 @@ static int person_email_atom_parser(struct ref_format *format UNUSED,
 				    const char *arg, struct strbuf *err)
 {
 	for (;;) {
-		int opt = email_atom_option_parser(atom, &arg, err);
+		int opt = email_atom_option_parser(&arg);
 		const char *bad_arg = arg;
 
 		if (opt < 0)

Original file line number	Diff line number	Diff line change
`@@ -742,8 +742,7 @@ static int person_name_atom_parser(struct ref_format *format UNUSED,`
`742`	`742`	`return 0;`
`743`	`743`	`}`
`744`	`744`
`745`		`-static int email_atom_option_parser(struct used_atom *atom,`
`746`		`- const char *arg, struct strbuf err)`
	`745`	`+static int email_atom_option_parser(const char **arg)`
`747`	`746`	`{`
`748`	`747`	`if (!*arg)`
`749`	`748`	`return EO_RAW;`
`@@ -761,7 +760,7 @@ static int person_email_atom_parser(struct ref_format *format UNUSED,`
`761`	`760`	`const char arg, struct strbuf err)`
`762`	`761`	`{`
`763`	`762`	`for (;;) {`
`764`		`- int opt = email_atom_option_parser(atom, &arg, err);`
	`763`	`+ int opt = email_atom_option_parser(&arg);`
`765`	`764`	`const char *bad_arg = arg;`
`766`	`765`
`767`	`766`	`if (opt < 0)`