Skip to content

Commit 5a0ee6f

Browse files
committed
Merge branch 'jc/doc-wholesale-replace-before-next'
Doc update. * jc/doc-wholesale-replace-before-next: SubmittingPatches: spell out "replace fully to pretend to be perfect"
2 parents accd0e1 + 476365a commit 5a0ee6f

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

Documentation/SubmittingPatches

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,18 @@ feedback before sending a new version, rather than sending an updated
5656
series immediately after receiving a review. This helps collect broader
5757
input and avoids unnecessary churn from many rapid iterations.
5858

59+
. These early update iterations are expected to be full replacements,
60+
not incremental updates on top of what you posted already. If you
61+
are correcting mistakes you made in the previous iteration that a
62+
reviewer noticed and pointed out in their review, you _fix_ that
63+
mistake by rewriting your history (e.g., by using "git rebase -i")
64+
to pretend that you never made the mistake in the first place. In
65+
other words, this is a chance to pretend to be a perfect developer,
66+
and you are expected to take advantage of that. In the larger
67+
picture, nobody is interested in your earlier mistakes. Just
68+
present a logical progression made by a perfect developer who makes
69+
no mistakes while working on the topic.
70+
5971
. Polish, refine, and re-send your patches to the list and to the people
6072
who spent their time to improve your patch. Go back to step (2).
6173

0 commit comments

Comments
 (0)