Skip to content

Commit 68af47e

Browse files
committed
merge-ort: replace the_repository with opt->repo
We have a perfectly valid repository available and do not need to use the_repository, except for one location in prefetch_for_content_merges(). Signed-off-by: Elijah Newren <newren@gmail.com>
1 parent 911cba9 commit 68af47e

1 file changed

Lines changed: 22 additions & 22 deletions

File tree

merge-ort.c

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1732,9 +1732,9 @@ static int collect_merge_info(struct merge_options *opt,
17321732
info.data = opt;
17331733
info.show_all_errors = 1;
17341734

1735-
if (repo_parse_tree(the_repository, merge_base) < 0 ||
1736-
repo_parse_tree(the_repository, side1) < 0 ||
1737-
repo_parse_tree(the_repository, side2) < 0)
1735+
if (repo_parse_tree(opt->repo, merge_base) < 0 ||
1736+
repo_parse_tree(opt->repo, side1) < 0 ||
1737+
repo_parse_tree(opt->repo, side2) < 0)
17381738
return -1;
17391739
init_tree_desc(t + 0, &merge_base->object.oid,
17401740
merge_base->buffer, merge_base->size);
@@ -2136,9 +2136,9 @@ static int merge_3way(struct merge_options *opt,
21362136
name2 = mkpathdup("%s:%s", opt->branch2, pathnames[2]);
21372137
}
21382138

2139-
read_mmblob(&orig, the_repository->objects, o);
2140-
read_mmblob(&src1, the_repository->objects, a);
2141-
read_mmblob(&src2, the_repository->objects, b);
2139+
read_mmblob(&orig, opt->repo->objects, o);
2140+
read_mmblob(&src1, opt->repo->objects, a);
2141+
read_mmblob(&src2, opt->repo->objects, b);
21422142

21432143
merge_status = ll_merge(result_buf, path, &orig, base,
21442144
&src1, name1, &src2, name2,
@@ -2254,7 +2254,7 @@ static int handle_content_merge(struct merge_options *opt,
22542254
}
22552255

22562256
if (!ret && record_object &&
2257-
odb_write_object(the_repository->objects, result_buf.ptr, result_buf.size,
2257+
odb_write_object(opt->repo->objects, result_buf.ptr, result_buf.size,
22582258
OBJ_BLOB, &result->oid)) {
22592259
path_msg(opt, ERROR_OBJECT_WRITE_FAILED, 0,
22602260
pathnames[0], pathnames[1], pathnames[2], NULL,
@@ -3713,7 +3713,7 @@ static int read_oid_strbuf(struct merge_options *opt,
37133713
void *buf;
37143714
enum object_type type;
37153715
unsigned long size;
3716-
buf = odb_read_object(the_repository->objects, oid, &type, &size);
3716+
buf = odb_read_object(opt->repo->objects, oid, &type, &size);
37173717
if (!buf) {
37183718
path_msg(opt, ERROR_OBJECT_READ_FAILED, 0,
37193719
path, NULL, NULL, NULL,
@@ -4439,7 +4439,7 @@ static void prefetch_for_content_merges(struct merge_options *opt,
44394439
struct string_list_item *e;
44404440
struct oid_array to_fetch = OID_ARRAY_INIT;
44414441

4442-
if (!repo_has_promisor_remote(the_repository))
4442+
if (!repo_has_promisor_remote(opt->repo))
44434443
return;
44444444

44454445
for (e = &plist->items[plist->nr-1]; e >= plist->items; --e) {
@@ -4619,10 +4619,10 @@ static int checkout(struct merge_options *opt,
46194619
unpack_opts.verbose_update = (opt->verbosity > 2);
46204620
unpack_opts.fn = twoway_merge;
46214621
unpack_opts.preserve_ignored = 0; /* FIXME: !opts->overwrite_ignore */
4622-
if (repo_parse_tree(the_repository, prev) < 0)
4622+
if (repo_parse_tree(opt->repo, prev) < 0)
46234623
return -1;
46244624
init_tree_desc(&trees[0], &prev->object.oid, prev->buffer, prev->size);
4625-
if (repo_parse_tree(the_repository, next) < 0)
4625+
if (repo_parse_tree(opt->repo, next) < 0)
46264626
return -1;
46274627
init_tree_desc(&trees[1], &next->object.oid, next->buffer, next->size);
46284628

@@ -5280,7 +5280,7 @@ static void merge_ort_nonrecursive_internal(struct merge_options *opt,
52805280

52815281
if (result->clean >= 0) {
52825282
if (!opt->mergeability_only) {
5283-
result->tree = repo_parse_tree_indirect(the_repository,
5283+
result->tree = repo_parse_tree_indirect(opt->repo,
52845284
&working_tree_oid);
52855285
if (!result->tree)
52865286
die(_("unable to read tree (%s)"),
@@ -5309,7 +5309,7 @@ static void merge_ort_internal(struct merge_options *opt,
53095309
struct strbuf merge_base_abbrev = STRBUF_INIT;
53105310

53115311
if (!merge_bases) {
5312-
if (repo_get_merge_bases(the_repository, h1, h2,
5312+
if (repo_get_merge_bases(opt->repo, h1, h2,
53135313
&merge_bases) < 0) {
53145314
result->clean = -1;
53155315
goto out;
@@ -5440,20 +5440,20 @@ static void merge_recursive_config(struct merge_options *opt, int ui)
54405440
{
54415441
char *value = NULL;
54425442
int renormalize = 0;
5443-
repo_config_get_int(the_repository, "merge.verbosity", &opt->verbosity);
5444-
repo_config_get_int(the_repository, "diff.renamelimit", &opt->rename_limit);
5445-
repo_config_get_int(the_repository, "merge.renamelimit", &opt->rename_limit);
5446-
repo_config_get_bool(the_repository, "merge.renormalize", &renormalize);
5443+
repo_config_get_int(opt->repo, "merge.verbosity", &opt->verbosity);
5444+
repo_config_get_int(opt->repo, "diff.renamelimit", &opt->rename_limit);
5445+
repo_config_get_int(opt->repo, "merge.renamelimit", &opt->rename_limit);
5446+
repo_config_get_bool(opt->repo, "merge.renormalize", &renormalize);
54475447
opt->renormalize = renormalize;
5448-
if (!repo_config_get_string(the_repository, "diff.renames", &value)) {
5448+
if (!repo_config_get_string(opt->repo, "diff.renames", &value)) {
54495449
opt->detect_renames = git_config_rename("diff.renames", value);
54505450
free(value);
54515451
}
5452-
if (!repo_config_get_string(the_repository, "merge.renames", &value)) {
5452+
if (!repo_config_get_string(opt->repo, "merge.renames", &value)) {
54535453
opt->detect_renames = git_config_rename("merge.renames", value);
54545454
free(value);
54555455
}
5456-
if (!repo_config_get_string(the_repository, "merge.directoryrenames", &value)) {
5456+
if (!repo_config_get_string(opt->repo, "merge.directoryrenames", &value)) {
54575457
int boolval = git_parse_maybe_bool(value);
54585458
if (0 <= boolval) {
54595459
opt->detect_directory_renames = boolval ?
@@ -5466,15 +5466,15 @@ static void merge_recursive_config(struct merge_options *opt, int ui)
54665466
free(value);
54675467
}
54685468
if (ui) {
5469-
if (!repo_config_get_string(the_repository, "diff.algorithm", &value)) {
5469+
if (!repo_config_get_string(opt->repo, "diff.algorithm", &value)) {
54705470
long diff_algorithm = parse_algorithm_value(value);
54715471
if (diff_algorithm < 0)
54725472
die(_("unknown value for config '%s': %s"), "diff.algorithm", value);
54735473
opt->xdl_opts = (opt->xdl_opts & ~XDF_DIFF_ALGORITHM_MASK) | diff_algorithm;
54745474
free(value);
54755475
}
54765476
}
5477-
repo_config(the_repository, git_xmerge_config, NULL);
5477+
repo_config(opt->repo, git_xmerge_config, NULL);
54785478
}
54795479

54805480
static void init_merge_options(struct merge_options *opt,

0 commit comments

Comments
 (0)